From: Wanlong Gao <gaowanlong@cn.fujitsu.com>
To: Zhouping Liu <zliu@redhat.com>
Cc: LTP List <ltp-list@lists.sourceforge.net>
Subject: Re: [LTP] [PATCH] numa/numa01.sh: fixed errors under noncontinuous numa nodes list
Date: Wed, 16 Jan 2013 15:16:35 +0800 [thread overview]
Message-ID: <50F653D3.9050407@cn.fujitsu.com> (raw)
In-Reply-To: <50ED5C7A.2050301@redhat.com>
On 01/09/2013 08:03 PM, Zhouping Liu wrote:
> On 01/09/2013 07:58 PM, Zhouping Liu wrote:
>> > The previous code numa01.sh thought all NUMA system had continuous
>> > numa nodes list, and node id started from 0, but in fact it does not.
>> >
>> > There are lots of system contains noncontinuous numa nodes list
>> > e.g:
>> > # numactl --hardware
>> > available: 4 nodes (0,2,4,7)
>> > node 0 cpus: 0 4 8 12 16 20 24 28
>> > node 0 size: 4061 MB
>> > node 0 free: 3756 MB
>> > node 2 cpus: 1 5 9 13 17 21 25 29
>> > node 2 size: 4096 MB
>> > node 2 free: 3196 MB
>> > node 4 cpus: 2 6 10 14 18 22 26 30
>> > node 4 size: 4096 MB
>> > node 4 free: 3885 MB
>> > node 7 cpus: 3 7 11 15 19 23 27 31
>> > node 7 size: 4095 MB
>> > node 7 free: 3947 MB
>> > node distances:
>> > node 0 2 4 7
>> > 0: 10 20 20 20
>> > 2: 20 10 20 20
>> > 4: 20 20 10 20
>> > 7: 20 20 20 10
>> >
>> > in such discontinuous nodes system, numa01.sh would fail with
>> > such error log:
>> > libnuma: Warning: node argument 1 is out of range
>> >
>> > The patch fixed it, and removed some useless/redundancy val/func,
>> > such as 'max_node' val and 'getmax' func, also make some cleanup.
> I tested the patch on continuous/non-continuous NUMA system, also did on
> non-NUMA system.
Applied, thank you.
Wanlong Gao
>
> Thanks,
> Zhouping
>
------------------------------------------------------------------------------
Master Java SE, Java EE, Eclipse, Spring, Hibernate, JavaScript, jQuery
and much more. Keep your Java skills current with LearnJavaNow -
200+ hours of step-by-step video tutorials by Java experts.
SALE $49.99 this month only -- learn more at:
http://p.sf.net/sfu/learnmore_122612
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2013-01-16 7:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-09 11:58 [LTP] [PATCH] numa/numa01.sh: fixed errors under noncontinuous numa nodes list Zhouping Liu
2013-01-09 12:03 ` Zhouping Liu
2013-01-16 7:16 ` Wanlong Gao [this message]
2013-01-14 1:25 ` Wanlong Gao
2013-01-14 1:55 ` Zhouping Liu
2013-01-14 2:08 ` Wanlong Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F653D3.9050407@cn.fujitsu.com \
--to=gaowanlong@cn.fujitsu.com \
--cc=ltp-list@lists.sourceforge.net \
--cc=zliu@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.