All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Fainelli <florian@openwrt.org>
To: Thierry Reding <thierry.reding@avionic-design.de>
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org
Subject: Re: [PATCH] MIPS: PNX8550: Fix build failures
Date: Wed, 16 Jan 2013 10:15:36 +0100	[thread overview]
Message-ID: <50F66FB8.7030207@openwrt.org> (raw)
In-Reply-To: <1358320033-30032-1-git-send-email-thierry.reding@avionic-design.de>

On 01/16/2013 08:07 AM, Thierry Reding wrote:
> The OHCI support code fails to build because the PCI_BASE and udelay()
> macros which are defined in pci.h and linux/time.h respectively. Adding
> corresponding includes fixes these build failures.
>
> Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>

Thanks for fixing this Thierry, I completely missed that when moving the 
OHCI code to platform.c

Acked-by: Florian Fainelli <florian@openwrt.org>

> ---
>   arch/mips/pnx8550/common/platform.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/arch/mips/pnx8550/common/platform.c b/arch/mips/pnx8550/common/platform.c
> index 0a8faea..9782fde 100644
> --- a/arch/mips/pnx8550/common/platform.c
> +++ b/arch/mips/pnx8550/common/platform.c
> @@ -19,10 +19,12 @@
>   #include <linux/resource.h>
>   #include <linux/serial.h>
>   #include <linux/serial_pnx8xxx.h>
> +#include <linux/delay.h>
>   #include <linux/platform_device.h>
>   #include <linux/usb/ohci_pdriver.h>
>   
>   #include <int.h>
> +#include <pci.h>
>   #include <usb.h>
>   #include <uart.h>
>   

  reply	other threads:[~2013-01-16  9:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-16  7:07 [PATCH] MIPS: PNX8550: Fix build failures Thierry Reding
2013-01-16  9:15 ` Florian Fainelli [this message]
2013-01-16  9:51 ` Geert Uytterhoeven
2013-01-16 10:03   ` Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50F66FB8.7030207@openwrt.org \
    --to=florian@openwrt.org \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    --cc=thierry.reding@avionic-design.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.