Re: [PATCH 2/2] decompressors: make the default XZ_BCJ_* config match the selected architecture

[Florian Fainelli <florian@openwrt.org>]

On 01/15/2013 07:11 PM, Lasse Collin wrote:
> On 2013-01-15 Florian Fainelli wrote:
>> This patch changes the defautl XZ_BCJ_* config symbol to match the
>> configured architecture. It is perfectly legitimate to support
>> multiple XZ BCJ filters for different architectures (e.g.: to mount
>> foreign squashfs/xz compressed filesystems), it is however more
>> natural not to select them all by default, but only the one matching
>> the configured architecture.
> I don't have a strong opinion on what is the best default setting, so
> it's fine to me that the default is changed if that's what people
> prefer.

I think it does make sense to have the default match the configured 
architecture, as it is very likely going to be used for that purpose.

>
>>   config XZ_DEC_X86
>>   	bool "x86 BCJ filter decoder" if EXPERT
>> -	default y
>> +	default y if X86
>>   	select XZ_DEC_BCJ
> [...]
>
> I think the "if EXPERT" strings should be dropped when all BCJ filters
> aren't enabled by default. One should be able to enable all filters
> without enabling EXPERT.
Ok, this would probably be a third patch, since my two patches basically 
just modify what was already there, but I agree with you, even though 
EXPERT is enabled by default on most architectures and defconfigs.
--
Florian