From: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: netdev@vger.kernel.org, YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Subject: Re: [RFC(v2) net-next 13/13] ipv6: Complete neighbour entry removal from dst_entry.
Date: Wed, 16 Jan 2013 23:04:35 +0900 [thread overview]
Message-ID: <50F6B373.5040106@linux-ipv6.org> (raw)
In-Reply-To: <50F6521F.4020706@gmail.com>
Cong Wang wrote:
> On 01/16/2013 12:46 AM, YOSHIFUJI Hideaki wrote:
>> +#if 0
>> if (rt->n && rt->n->dev == dev) {
>> rt->n->dev = loopback_dev;
>> dev_hold(loopback_dev);
>> dev_put(dev);
>> }
>> +#endif
>
> Why commenting this out instead of removing it? As rt->n is totally
> removed, how possible could we reuse this code in future?
I have confirmed that this dev_put()/dev_hold() operation are really
for neigh->dev, which has refcnt for dev, so I agree.
(This is why I need to revisit refcnt
--yoshfuji
prev parent reply other threads:[~2013-01-16 14:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-15 16:46 [RFC(v2) net-next 13/13] ipv6: Complete neighbour entry removal from dst_entry YOSHIFUJI Hideaki
2013-01-16 7:09 ` Cong Wang
2013-01-16 14:04 ` YOSHIFUJI Hideaki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F6B373.5040106@linux-ipv6.org \
--to=yoshfuji@linux-ipv6.org \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.