From: Stefan Roese <stefan.roese@gmail.com>
To: dedekind1@gmail.com
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH v2] mtd: cfi_cmdset_0002: Support Persistent Protection Bits (PPB) locking
Date: Wed, 16 Jan 2013 15:28:31 +0100 [thread overview]
Message-ID: <50F6B90F.8080905@gmail.com> (raw)
In-Reply-To: <1358241038.2731.118.camel@sauron.fi.intel.com>
On 01/15/2013 10:10 AM, Artem Bityutskiy wrote:
> On Thu, 2012-12-13 at 09:29 +0100, Stefan Roese wrote:
>> Currently cfi_cmdset_0002.c does not support PPB locking of sectors. This
>> patch adds support for this locking/unlocking mechanism. It is needed on
>> some platforms, since newer U-Boot versions do support this PPB locking
>> and protect for example their environment sector(s) this way.
>
> Some "#ifdef CONFIG_OF"s are missing:
>
> drivers/mtd/chips/cfi_cmdset_0002.c: In function ‘cfi_cmdset_0002’:
> drivers/mtd/chips/cfi_cmdset_0002.c:579:4: error: implicit declaration of function ‘of_property_read_bool’ [-Werror=implicit-function-declaration]
Okay. Will add in next version.
> drivers/mtd/chips/cfi_cmdset_0002.c: In function ‘do_read_secsi_onechip’:
> drivers/mtd/chips/cfi_cmdset_0002.c:1146:16: warning: variable ‘timeo’ set but not used [-Wunused-but-set-variable]
> cc1: some warnings being treated as errors
> make[4]: *** [drivers/mtd/chips/cfi_cmdset_0002.o] Error 1
>
> Please, check allso the timeo warning.
Hmmm. I didn't touch do_read_secsi_onechip() with this patch. And I'm
not able to reproduce this warning. Are you sure this warning is
introduced by this PPB locking patch?
Thanks,
Stefan
next prev parent reply other threads:[~2013-01-16 14:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-13 8:29 [PATCH v2] mtd: cfi_cmdset_0002: Support Persistent Protection Bits (PPB) locking Stefan Roese
2012-12-13 8:29 ` Stefan Roese
2013-01-15 9:10 ` Artem Bityutskiy
2013-01-15 9:10 ` Artem Bityutskiy
2013-01-16 14:28 ` Stefan Roese [this message]
2013-01-17 12:10 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F6B90F.8080905@gmail.com \
--to=stefan.roese@gmail.com \
--cc=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.