From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH 04/11] readline: Fix unchecked strdup() by converting to g_strdup()
Date: Wed, 16 Jan 2013 08:51:32 -0700 [thread overview]
Message-ID: <50F6CC84.8000908@redhat.com> (raw)
In-Reply-To: <1358346998-26328-5-git-send-email-armbru@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1040 bytes --]
On 01/16/2013 07:36 AM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> readline.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/readline.c b/readline.c
> index a0c9638..d6e04d4 100644
> --- a/readline.c
> +++ b/readline.c
> @@ -247,14 +247,14 @@ static void readline_hist_add(ReadLineState *rs, const char *cmdline)
> }
> if (idx == READLINE_MAX_CMDS) {
> /* Need to get one free slot */
> - free(rs->history[0]);
> + g_free(rs->history[0]);
> memmove(rs->history, &rs->history[1],
> (READLINE_MAX_CMDS - 1) * sizeof(char *));
> rs->history[READLINE_MAX_CMDS - 1] = NULL;
> idx = READLINE_MAX_CMDS - 1;
> }
> if (new_entry == NULL)
> - new_entry = strdup(cmdline);
> + new_entry = g_strdup(cmdline);
As long as you are converting tabs to spaces, you should also be adding {}.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 04/11] readline: Fix unchecked strdup() by converting to g_strdup()
Date: Wed, 16 Jan 2013 08:51:32 -0700 [thread overview]
Message-ID: <50F6CC84.8000908@redhat.com> (raw)
In-Reply-To: <1358346998-26328-5-git-send-email-armbru@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1040 bytes --]
On 01/16/2013 07:36 AM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> readline.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/readline.c b/readline.c
> index a0c9638..d6e04d4 100644
> --- a/readline.c
> +++ b/readline.c
> @@ -247,14 +247,14 @@ static void readline_hist_add(ReadLineState *rs, const char *cmdline)
> }
> if (idx == READLINE_MAX_CMDS) {
> /* Need to get one free slot */
> - free(rs->history[0]);
> + g_free(rs->history[0]);
> memmove(rs->history, &rs->history[1],
> (READLINE_MAX_CMDS - 1) * sizeof(char *));
> rs->history[READLINE_MAX_CMDS - 1] = NULL;
> idx = READLINE_MAX_CMDS - 1;
> }
> if (new_entry == NULL)
> - new_entry = strdup(cmdline);
> + new_entry = g_strdup(cmdline);
As long as you are converting tabs to spaces, you should also be adding {}.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
next prev parent reply other threads:[~2013-01-16 15:51 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-16 14:36 [Qemu-trivial] [PATCH 00/11] Trivial memory allocation fixes & cleanups Markus Armbruster
2013-01-16 14:36 ` [Qemu-devel] " Markus Armbruster
2013-01-16 14:36 ` [Qemu-trivial] [PATCH 01/11] g_malloc(0) and g_malloc0(0) return NULL; simplify Markus Armbruster
2013-01-16 14:36 ` [Qemu-devel] " Markus Armbruster
2013-01-16 14:36 ` [Qemu-trivial] [PATCH 02/11] g_strdup(NULL) returns " Markus Armbruster
2013-01-16 14:36 ` [Qemu-devel] " Markus Armbruster
2013-01-16 14:36 ` [Qemu-trivial] [PATCH 03/11] hw/9pfs: Fix unchecked strdup() by converting to g_strdup() Markus Armbruster
2013-01-16 14:36 ` [Qemu-devel] " Markus Armbruster
2013-01-16 14:36 ` [Qemu-trivial] [PATCH 04/11] readline: " Markus Armbruster
2013-01-16 14:36 ` [Qemu-devel] " Markus Armbruster
2013-01-16 15:51 ` Eric Blake [this message]
2013-01-16 15:51 ` Eric Blake
2013-01-16 16:03 ` [Qemu-trivial] " Markus Armbruster
2013-01-16 16:03 ` Markus Armbruster
2013-01-16 14:36 ` [Qemu-trivial] [PATCH 05/11] spice: " Markus Armbruster
2013-01-16 14:36 ` [Qemu-devel] " Markus Armbruster
2013-01-16 14:36 ` [Qemu-trivial] [PATCH 06/11] virtfs-proxy-helper: Fix unchecked strdup() by conv. " Markus Armbruster
2013-01-16 14:36 ` [Qemu-devel] " Markus Armbruster
2013-01-16 14:36 ` [Qemu-trivial] [PATCH 07/11] qemu-log: Fix unchecked strdup() by converting " Markus Armbruster
2013-01-16 14:36 ` [Qemu-devel] " Markus Armbruster
2013-01-16 14:36 ` [Qemu-trivial] [PATCH 08/11] qemu-log: Plug trivial memory leak in cpu_set_log_filename() Markus Armbruster
2013-01-16 14:36 ` [Qemu-devel] " Markus Armbruster
2013-01-16 15:53 ` [Qemu-trivial] " Eric Blake
2013-01-16 15:53 ` Eric Blake
2013-01-16 16:06 ` [Qemu-trivial] " Markus Armbruster
2013-01-16 16:06 ` Markus Armbruster
2013-01-17 20:49 ` [Qemu-trivial] " Blue Swirl
2013-01-17 20:49 ` Blue Swirl
2013-01-16 14:36 ` [Qemu-trivial] [PATCH 09/11] libcacard: Fix unchecked strdup() by converting to g_strdup() Markus Armbruster
2013-01-16 14:36 ` [Qemu-devel] " Markus Armbruster
2013-01-16 14:36 ` [Qemu-trivial] [PATCH 10/11] qapi: " Markus Armbruster
2013-01-16 14:36 ` [Qemu-devel] " Markus Armbruster
2013-01-16 14:36 ` [Qemu-trivial] [PATCH 11/11] qemu-ga: " Markus Armbruster
2013-01-16 14:36 ` [Qemu-devel] " Markus Armbruster
2013-01-16 15:54 ` [Qemu-trivial] [Qemu-devel] [PATCH 00/11] Trivial memory allocation fixes & cleanups Eric Blake
2013-01-16 15:54 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F6CC84.8000908@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.