From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34594) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TvXCB-0002eW-DN for qemu-devel@nongnu.org; Wed, 16 Jan 2013 12:54:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TvXCA-00075Y-0M for qemu-devel@nongnu.org; Wed, 16 Jan 2013 12:54:39 -0500 Received: from mx1.redhat.com ([209.132.183.28]:17382) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TvXC9-00075O-M7 for qemu-devel@nongnu.org; Wed, 16 Jan 2013 12:54:37 -0500 Message-ID: <50F6E95A.4090401@redhat.com> Date: Wed, 16 Jan 2013 10:54:34 -0700 From: Eric Blake MIME-Version: 1.0 References: <1358349851-20960-1-git-send-email-ehabkost@redhat.com> <1358349851-20960-7-git-send-email-ehabkost@redhat.com> <50F6E28B.1010603@redhat.com> <20130116174236.GD10683@otherpad.lan.raisama.net> In-Reply-To: <20130116174236.GD10683@otherpad.lan.raisama.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2GDQAACEIATOIHBEWLCBB" Subject: Re: [Qemu-devel] [PATCH 6/8] vl.c: Use parse_uint_full() for NUMA nodeid List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: Chegu Vinod , qemu-devel@nongnu.org, Anthony Liguori This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2GDQAACEIATOIHBEWLCBB Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 01/16/2013 10:42 AM, Eduardo Habkost wrote: >=20 > Or, we could simply change the meaning of "nodeid=3D010" and document i= t > in the commit message and QEMU ChageLog. Which option do the QEMU > maintainers prefer? I'm not a maintainer, so anyone is free to overrule me; but I'm personally fine with just documenting that the semantic change is intentional. It's enough of a corner case that probably no one was relying on leading 0 still giving decimal parsing (libvirt certainly wasn't relying on it], and the flexibility of allowing hex parsing is useful. But do document it in the commit message; a silent change is not fair. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2GDQAACEIATOIHBEWLCBB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJQ9ulaAAoJEKeha0olJ0NqyqYH/2Z+HDobYE8v6q0umcuzdUEL fUKkg51yVbxXP2kqkLUH7i69J+3oE8IntfALzZEe6G6FaXmyJXTEYRx2fe6GPiAO BjB+kNt8DvJ79OS7dozowEzHcyPKuPZIhX2dQO6o9Z5fZz3ZhvFMpAiBcu/90l2H mY2lr8Awd3+2dp7ZBJZ9qAw+L8zdoUJJQ64eOlzPJaytJKkcjzgVetRd/SsPBXpf 7lSHFauAK1154IUzxHQpYawZvOSe/KIY73dc9e5y7Gfak4pFLQ2CjV7LpmsJW2i/ oAUZEUh5q127Muond3OUwp6QJKBQ/MbKh0oIa0iOfbuFHljXCek2riqOjdnOHy0= =gyxC -----END PGP SIGNATURE----- ------enig2GDQAACEIATOIHBEWLCBB--