From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55513) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TvcT6-0005dt-8s for qemu-devel@nongnu.org; Wed, 16 Jan 2013 18:32:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TvcT4-0002uE-FR for qemu-devel@nongnu.org; Wed, 16 Jan 2013 18:32:28 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41485) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TvcT4-0002u4-85 for qemu-devel@nongnu.org; Wed, 16 Jan 2013 18:32:26 -0500 Message-ID: <50F73884.9010307@redhat.com> Date: Wed, 16 Jan 2013 16:32:20 -0700 From: Eric Blake MIME-Version: 1.0 References: <1358353518-5421-1-git-send-email-benoit@irqsave.net> <1358353518-5421-12-git-send-email-benoit@irqsave.net> In-Reply-To: <1358353518-5421-12-git-send-email-benoit@irqsave.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2GTKROEHPGVFXIQSEJAQN" Subject: Re: [Qemu-devel] [RFC V1 11/12] qmp: Add block-pause-dedup. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QmVub8OudCBDYW5ldA==?= Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2GTKROEHPGVFXIQSEJAQN Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 01/16/2013 09:25 AM, Beno=C3=AEt Canet wrote: > --- > blockdev.c | 18 ++++++++++++++++++ > qapi-schema.json | 18 ++++++++++++++++++ > qmp-commands.hx | 23 +++++++++++++++++++++++ > 3 files changed, 59 insertions(+) >=20 > =20 > ## > +# @block-pause-dedup: > +# > +# This command pause the deduplication on a device that support it. s/support/supports/ > +# > +# @device: the name of the device to pause the deduplication on > +# > +# Returns: nothing on success > +# If @device is not a valid block device, DeviceNotFound > +# If @device is not deduplicated, DeviceNotDeduplicated I don't think you need this second error. A generic error is good enough unless we can prove that having a dedicated error class makes algorithmic sense for a given client, and I can't come up with such a scenario off the top of my head for libvirt. > +SQMP > +block-pause-dedup > +------------ > + > +Pause the deduplication on a device that support it. s/support/supports/ I notice that between this and patch 12, you are adding two very similar commands (block-pause-dedup, block-resume-dedup); would it be any simpler to add a single command instead: { 'command': 'block-dedup-control', 'data': { 'device': 'str', 'enable': 'bool' } } where the user calls: { "execute": "block-dedup-control", "arguments": { "device": "ide0-hd0", "enable": false } } to pause, and "enable":true to resume? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2GTKROEHPGVFXIQSEJAQN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJQ9ziEAAoJEKeha0olJ0NqSckH/AuV3zHJC5OLcN6aPJ4JFRnE +Jx5YqXGD+qiK1s8BCFl6xNgPReJpv3qj4z00m8FrDcioaCVfLdAs20vuzV16yjl ZLsEhGjnEOLRnDC8HPZAvKTIyn/VJ8mQTfgvc4jNf2GizMqZf/Hzsqt6m63N8niD 4fVhhkv/5lVRqCOpPVjKRbf3xt19W6cUasGJDvycMMwXgW3UqKHUhTWqmuGW9iB0 EYA2CVFfZC1r5yxCwb2PmWaUPg1RFFizE95d4ZhUxTEPCwfaJkJ+3+juIw6+ljsp A659+xieK2SCQOeeRAszMLn3Hm5y0IpjRUnjNp9ANL/54AVk/i1gp5RfQ7KTJ7c= =EsTF -----END PGP SIGNATURE----- ------enig2GTKROEHPGVFXIQSEJAQN--