Re: [PATCH REPOST 0/4] rbd: explicitly support only one osd op

[Josh Durgin <josh.durgin@inktank.com>]

On 01/04/2013 06:43 AM, Alex Elder wrote:
> An osd request can be made up of multiple "ops", all of which are
> completed (or not) transactionally.  There is partial support for
> multiple ops in an rbd request in the rbd code, but it's incomplete
> and not even supported by the osd client or the messenger right now.
>
> I see three problems with this partial implementation:  it gives a
> false impression of how things work; it complicates some code in
> some cases where it's not necessary; and it may constrain how one
> might pursue fully implementing multiple ops in a request to ways
> that don't fit well with how we want to do things.
>
> So this series just simplifies things, making it explicit that there
> is only one op in an kernel osd client request right now.
>
> 					-Alex
>
> [PATCH REPOST 1/4] rbd: pass num_op with ops array
> [PATCH REPOST 2/4] libceph: pass num_op with ops
> [PATCH REPOST 3/4] rbd: there is really only one op
> [PATCH REPOST 4/4] rbd: assume single op in a request

These look good.

Reviewed-by: Josh Durgin <josh.durgin@inktank.com>