From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40662) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tvkuu-0000UC-4i for qemu-devel@nongnu.org; Thu, 17 Jan 2013 03:33:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tvkut-0007uo-1E for qemu-devel@nongnu.org; Thu, 17 Jan 2013 03:33:43 -0500 Message-ID: <50F7B764.9070702@msgid.tls.msk.ru> Date: Thu, 17 Jan 2013 12:33:40 +0400 From: Michael Tokarev MIME-Version: 1.0 References: <1358367600-8074-1-git-send-email-kwolf@redhat.com> <1358367600-8074-2-git-send-email-kwolf@redhat.com> In-Reply-To: <1358367600-8074-2-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [Qemu-stable] [PATCH 1/2] win32-aio: Fix vectored reads List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, qemu-stable@nongnu.org 17.01.2013 00:19, Kevin Wolf =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > Copying data in the right direction really helps a lot! > > Cc: qemu-stable@nongnu.org > Signed-off-by: Kevin Wolf > --- > block/win32-aio.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/block/win32-aio.c b/block/win32-aio.c > index 46a5db7..53b82e6 100644 > --- a/block/win32-aio.c > +++ b/block/win32-aio.c > @@ -84,7 +84,7 @@ static void win32_aio_process_completion(QEMUWin32AIO= State *s, > int i; > > for (i =3D 0; i < qiov->niov; ++i) { > - memcpy(p, qiov->iov[i].iov_base, qiov->iov[i].iov_len)= ; > + memcpy(qiov->iov[i].iov_base, p, qiov->iov[i].iov_len)= ; > p +=3D qiov->iov[i].iov_len; > } > g_free(waiocb->buf); Actually this is just iov_from_buf(qiov->iov, qiov->niov, 0, waiocb->buf, -1); Or is it iov_to_buf() ? :) Thanks, /mjt