From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roger Quadros Subject: Re: [RFC PATCH 2/6] ARM: OMAP: USB: Add phy binding information Date: Thu, 17 Jan 2013 11:39:19 +0200 Message-ID: <50F7C6C7.3030400@ti.com> References: <1358348462-27693-1-git-send-email-kishon@ti.com> <1358348462-27693-3-git-send-email-kishon@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1358348462-27693-3-git-send-email-kishon@ti.com> Sender: linux-doc-owner@vger.kernel.org To: Kishon Vijay Abraham I Cc: devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org, linux-sh@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, balbi@ti.com, grant.likely@secretlab.ca, rob.herring@calxeda.com, rob@landley.net, b-cousson@ti.com, tony@atomide.com, linux@arm.linux.org.uk, horms@verge.net.au, magnus.damm@gmail.com, cbou@mail.ru, dwmw2@infradead.org, alexander.shishkin@linux.intel.com, gregkh@linuxfoundation.org, leoli@freescale.com, eric.y.miao@gmail.com, haojian.zhuang@gmail.com, stern@rowland.harvard.edu List-Id: linux-omap@vger.kernel.org On 01/16/2013 05:00 PM, Kishon Vijay Abraham I wrote: > This is in preparation for the changes in PHY library to support adding > and getting multiple PHYs of the same type. In the new design, the > binding information between the PHY and the USB controller should be > specified in the platform specific initialization code. So it's been > done for OMAP platforms here. > > Signed-off-by: Kishon Vijay Abraham I > --- > This kind-of binding should be done in all the platforms (I've done only > for OMAP platform). > arch/arm/mach-omap2/usb-musb.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/mach-omap2/usb-musb.c b/arch/arm/mach-omap2/usb-musb.c > index 9d27e3f..bbe2fa5 100644 > --- a/arch/arm/mach-omap2/usb-musb.c > +++ b/arch/arm/mach-omap2/usb-musb.c > @@ -24,6 +24,7 @@ > #include > #include > #include > +#include > > #include "omap_device.h" > #include "soc.h" > @@ -85,8 +86,12 @@ void __init usb_musb_init(struct omap_musb_board_data *musb_board_data) > musb_plat.mode = board_data->mode; > musb_plat.extvbus = board_data->extvbus; > > - if (cpu_is_omap44xx()) > + if (cpu_is_omap44xx()) { > musb_plat.has_mailbox = true; > + usb_bind_phy("musb-hdrc.0.auto", 0, "omap-usb2.1.auto"); > + } else if (cpu_is_omap34xx()) { > + usb_bind_phy("musb-hdrc.0.auto", 0, "twl4030_usb"); > + } Are you sure than these OMAP platforms cannot be wired in any other way to the PHY? If they can be then this association must come from the board files or device tree. > > if (soc_is_am35xx()) { > oh_name = "am35x_otg_hs"; > -- cheers, -roger From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roger Quadros Date: Thu, 17 Jan 2013 09:39:19 +0000 Subject: Re: [RFC PATCH 2/6] ARM: OMAP: USB: Add phy binding information Message-Id: <50F7C6C7.3030400@ti.com> List-Id: References: <1358348462-27693-1-git-send-email-kishon@ti.com> <1358348462-27693-3-git-send-email-kishon@ti.com> In-Reply-To: <1358348462-27693-3-git-send-email-kishon@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org On 01/16/2013 05:00 PM, Kishon Vijay Abraham I wrote: > This is in preparation for the changes in PHY library to support adding > and getting multiple PHYs of the same type. In the new design, the > binding information between the PHY and the USB controller should be > specified in the platform specific initialization code. So it's been > done for OMAP platforms here. > > Signed-off-by: Kishon Vijay Abraham I > --- > This kind-of binding should be done in all the platforms (I've done only > for OMAP platform). > arch/arm/mach-omap2/usb-musb.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/mach-omap2/usb-musb.c b/arch/arm/mach-omap2/usb-musb.c > index 9d27e3f..bbe2fa5 100644 > --- a/arch/arm/mach-omap2/usb-musb.c > +++ b/arch/arm/mach-omap2/usb-musb.c > @@ -24,6 +24,7 @@ > #include > #include > #include > +#include > > #include "omap_device.h" > #include "soc.h" > @@ -85,8 +86,12 @@ void __init usb_musb_init(struct omap_musb_board_data *musb_board_data) > musb_plat.mode = board_data->mode; > musb_plat.extvbus = board_data->extvbus; > > - if (cpu_is_omap44xx()) > + if (cpu_is_omap44xx()) { > musb_plat.has_mailbox = true; > + usb_bind_phy("musb-hdrc.0.auto", 0, "omap-usb2.1.auto"); > + } else if (cpu_is_omap34xx()) { > + usb_bind_phy("musb-hdrc.0.auto", 0, "twl4030_usb"); > + } Are you sure than these OMAP platforms cannot be wired in any other way to the PHY? If they can be then this association must come from the board files or device tree. > > if (soc_is_am35xx()) { > oh_name = "am35x_otg_hs"; > -- cheers, -roger From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <50F7C6C7.3030400@ti.com> Date: Thu, 17 Jan 2013 11:39:19 +0200 From: Roger Quadros MIME-Version: 1.0 To: Kishon Vijay Abraham I Subject: Re: [RFC PATCH 2/6] ARM: OMAP: USB: Add phy binding information References: <1358348462-27693-1-git-send-email-kishon@ti.com> <1358348462-27693-3-git-send-email-kishon@ti.com> In-Reply-To: <1358348462-27693-3-git-send-email-kishon@ti.com> Content-Type: text/plain; charset="ISO-8859-1" Cc: linux-doc@vger.kernel.org, tony@atomide.com, linux@arm.linux.org.uk, linux-sh@vger.kernel.org, alexander.shishkin@linux.intel.com, stern@rowland.harvard.edu, devicetree-discuss@lists.ozlabs.org, linuxppc-dev@lists.ozlabs.org, rob.herring@calxeda.com, horms@verge.net.au, haojian.zhuang@gmail.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, eric.y.miao@gmail.com, b-cousson@ti.com, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, balbi@ti.com, cbou@mail.ru, rob@landley.net, dwmw2@infradead.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 01/16/2013 05:00 PM, Kishon Vijay Abraham I wrote: > This is in preparation for the changes in PHY library to support adding > and getting multiple PHYs of the same type. In the new design, the > binding information between the PHY and the USB controller should be > specified in the platform specific initialization code. So it's been > done for OMAP platforms here. > > Signed-off-by: Kishon Vijay Abraham I > --- > This kind-of binding should be done in all the platforms (I've done only > for OMAP platform). > arch/arm/mach-omap2/usb-musb.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/mach-omap2/usb-musb.c b/arch/arm/mach-omap2/usb-musb.c > index 9d27e3f..bbe2fa5 100644 > --- a/arch/arm/mach-omap2/usb-musb.c > +++ b/arch/arm/mach-omap2/usb-musb.c > @@ -24,6 +24,7 @@ > #include > #include > #include > +#include > > #include "omap_device.h" > #include "soc.h" > @@ -85,8 +86,12 @@ void __init usb_musb_init(struct omap_musb_board_data *musb_board_data) > musb_plat.mode = board_data->mode; > musb_plat.extvbus = board_data->extvbus; > > - if (cpu_is_omap44xx()) > + if (cpu_is_omap44xx()) { > musb_plat.has_mailbox = true; > + usb_bind_phy("musb-hdrc.0.auto", 0, "omap-usb2.1.auto"); > + } else if (cpu_is_omap34xx()) { > + usb_bind_phy("musb-hdrc.0.auto", 0, "twl4030_usb"); > + } Are you sure than these OMAP platforms cannot be wired in any other way to the PHY? If they can be then this association must come from the board files or device tree. > > if (soc_is_am35xx()) { > oh_name = "am35x_otg_hs"; > -- cheers, -roger From mboxrd@z Thu Jan 1 00:00:00 1970 From: rogerq@ti.com (Roger Quadros) Date: Thu, 17 Jan 2013 11:39:19 +0200 Subject: [RFC PATCH 2/6] ARM: OMAP: USB: Add phy binding information In-Reply-To: <1358348462-27693-3-git-send-email-kishon@ti.com> References: <1358348462-27693-1-git-send-email-kishon@ti.com> <1358348462-27693-3-git-send-email-kishon@ti.com> Message-ID: <50F7C6C7.3030400@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 01/16/2013 05:00 PM, Kishon Vijay Abraham I wrote: > This is in preparation for the changes in PHY library to support adding > and getting multiple PHYs of the same type. In the new design, the > binding information between the PHY and the USB controller should be > specified in the platform specific initialization code. So it's been > done for OMAP platforms here. > > Signed-off-by: Kishon Vijay Abraham I > --- > This kind-of binding should be done in all the platforms (I've done only > for OMAP platform). > arch/arm/mach-omap2/usb-musb.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/mach-omap2/usb-musb.c b/arch/arm/mach-omap2/usb-musb.c > index 9d27e3f..bbe2fa5 100644 > --- a/arch/arm/mach-omap2/usb-musb.c > +++ b/arch/arm/mach-omap2/usb-musb.c > @@ -24,6 +24,7 @@ > #include > #include > #include > +#include > > #include "omap_device.h" > #include "soc.h" > @@ -85,8 +86,12 @@ void __init usb_musb_init(struct omap_musb_board_data *musb_board_data) > musb_plat.mode = board_data->mode; > musb_plat.extvbus = board_data->extvbus; > > - if (cpu_is_omap44xx()) > + if (cpu_is_omap44xx()) { > musb_plat.has_mailbox = true; > + usb_bind_phy("musb-hdrc.0.auto", 0, "omap-usb2.1.auto"); > + } else if (cpu_is_omap34xx()) { > + usb_bind_phy("musb-hdrc.0.auto", 0, "twl4030_usb"); > + } Are you sure than these OMAP platforms cannot be wired in any other way to the PHY? If they can be then this association must come from the board files or device tree. > > if (soc_is_am35xx()) { > oh_name = "am35x_otg_hs"; > -- cheers, -roger From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759424Ab3AQJj4 (ORCPT ); Thu, 17 Jan 2013 04:39:56 -0500 Received: from comal.ext.ti.com ([198.47.26.152]:37688 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756081Ab3AQJjy (ORCPT ); Thu, 17 Jan 2013 04:39:54 -0500 Message-ID: <50F7C6C7.3030400@ti.com> Date: Thu, 17 Jan 2013 11:39:19 +0200 From: Roger Quadros User-Agent: Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/20121011 Thunderbird/16.0.1 MIME-Version: 1.0 To: Kishon Vijay Abraham I CC: , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [RFC PATCH 2/6] ARM: OMAP: USB: Add phy binding information References: <1358348462-27693-1-git-send-email-kishon@ti.com> <1358348462-27693-3-git-send-email-kishon@ti.com> In-Reply-To: <1358348462-27693-3-git-send-email-kishon@ti.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/16/2013 05:00 PM, Kishon Vijay Abraham I wrote: > This is in preparation for the changes in PHY library to support adding > and getting multiple PHYs of the same type. In the new design, the > binding information between the PHY and the USB controller should be > specified in the platform specific initialization code. So it's been > done for OMAP platforms here. > > Signed-off-by: Kishon Vijay Abraham I > --- > This kind-of binding should be done in all the platforms (I've done only > for OMAP platform). > arch/arm/mach-omap2/usb-musb.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/mach-omap2/usb-musb.c b/arch/arm/mach-omap2/usb-musb.c > index 9d27e3f..bbe2fa5 100644 > --- a/arch/arm/mach-omap2/usb-musb.c > +++ b/arch/arm/mach-omap2/usb-musb.c > @@ -24,6 +24,7 @@ > #include > #include > #include > +#include > > #include "omap_device.h" > #include "soc.h" > @@ -85,8 +86,12 @@ void __init usb_musb_init(struct omap_musb_board_data *musb_board_data) > musb_plat.mode = board_data->mode; > musb_plat.extvbus = board_data->extvbus; > > - if (cpu_is_omap44xx()) > + if (cpu_is_omap44xx()) { > musb_plat.has_mailbox = true; > + usb_bind_phy("musb-hdrc.0.auto", 0, "omap-usb2.1.auto"); > + } else if (cpu_is_omap34xx()) { > + usb_bind_phy("musb-hdrc.0.auto", 0, "twl4030_usb"); > + } Are you sure than these OMAP platforms cannot be wired in any other way to the PHY? If they can be then this association must come from the board files or device tree. > > if (soc_is_am35xx()) { > oh_name = "am35x_otg_hs"; > -- cheers, -roger