All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurentiu Palcu <laurentiu.palcu@intel.com>
To: Hongxu Jia <hongxu.jia@windriver.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/4] gtk-icon-cache.bbclass:fix support postrm at image creation time
Date: Thu, 17 Jan 2013 11:51:51 +0200	[thread overview]
Message-ID: <50F7C9B7.9030002@intel.com> (raw)
In-Reply-To: <50F7C6DA.9030502@windriver.com>



On 01/17/2013 11:39 AM, Hongxu Jia wrote:
> On 01/17/2013 05:10 PM, Laurentiu Palcu wrote:
>>
>> On 01/17/2013 09:07 AM, Hongxu Jia wrote:
>>>   gtk_icon_cache_postrm() {
>>> +if [ "$D" != "" ]; then
>>> +    for icondir in $D/usr/share/icons/* ; do
>>> +        if [ -d $icondir ] ; then
>>> +            gtk-update-icon-cache -qt  $icondir
>>> +        fi
>>> +    done
>>> +    exit 0
>>> +fi
>> I think you can just exit 0 here and let the hook in intercept-scripts
>> directory do the rest. The hook was added in the postinst and it will
>> properly call gtk-update-icon-cache. If you look in the log.do_rootfs
>> you'll see that the intercept scripts are run at the end (just look for
>> "Running intercept scripts"). So, I don't think you need to do this loop
>> here. Besides, it will be called for every postrm and running
>> gtk-update-icon-cache is not cheap...
>>
>> Thanks,
>> Laurentiu
> Ok, I will work on it to let the hook in intercept-scripts do the rest.
I just realized that, in order for the hook to be installed, the postint
scriptlet has to be run in the same do_rootfs session, otherwise the
hook will not be installed... In which case you might want to do that in
the postrm itself (like it was done for postinst).

Thanks,
Laurentiu

> 
> Thanks,
> Hongxu
> 



  reply	other threads:[~2013-01-17 10:07 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-17  7:07 [PATCH 0/4]fix support postrm/prerm at image creation time Hongxu Jia
2013-01-17  7:07 ` [PATCH 1/4] gtk-icon-cache.bbclass:fix support postrm " Hongxu Jia
2013-01-17  9:10   ` Laurentiu Palcu
2013-01-17  9:39     ` Hongxu Jia
2013-01-17  9:51       ` Laurentiu Palcu [this message]
2013-01-17  9:26   ` Martin Jansa
2013-01-17  7:07 ` [PATCH 2/4] update-rc.d:fix " Hongxu Jia
2013-01-17  7:07 ` [PATCH 3/4] libnss-mdns:fix support prerm " Hongxu Jia
2013-01-17  9:28   ` Martin Jansa
2013-01-17 10:48     ` Hongxu Jia
2013-01-17 12:35       ` Martin Jansa
2013-01-17  7:07 ` [PATCH 4/4] gtk-immodules-cache.bbclass:fix support postrm " Hongxu Jia
2013-01-17  9:52   ` Burton, Ross
2013-01-17 10:38     ` Hongxu Jia
  -- strict thread matches above, loose matches on Subject: below --
2013-01-17 12:56 [PATCH V2 0/4]fix support postrm/prerm " Hongxu Jia
2013-01-17 12:56 ` [PATCH 1/4] gtk-icon-cache.bbclass:fix support postrm " Hongxu Jia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50F7C9B7.9030002@intel.com \
    --to=laurentiu.palcu@intel.com \
    --cc=hongxu.jia@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.