From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Mortimer Date: Thu, 17 Jan 2013 10:41:59 +0000 Subject: Re: [PATCH v2] sparc: kernel/sbus.c: fix memory leakage Message-Id: <50F7D577.8010506@oldelvet.org.uk> List-Id: References: <1358199372-11976-1-git-send-email-dinggnu@gmail.com> <20130116211309.GA13993@merkur.ravnborg.org> <20130116211725.GC18593@gmail.com> <20130116220018.GA14063@merkur.ravnborg.org> <20130116220153.GD18593@gmail.com> In-Reply-To: <20130116220153.GD18593@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Cong Ding Cc: Sam Ravnborg , "David S. Miller" , sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org On 16/01/2013 22:01, Cong Ding wrote: > the variable iommu and strbuf are not freed if it goes to error. > > Signed-off-by: Cong Ding > --- > arch/sparc/kernel/sbus.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/sparc/kernel/sbus.c b/arch/sparc/kernel/sbus.c > index 1271b3a..78aa26b 100644 > --- a/arch/sparc/kernel/sbus.c > +++ b/arch/sparc/kernel/sbus.c > @@ -656,6 +656,8 @@ static void __init sbus_iommu_init(struct platform_device *op) > return; > > fatal_memory_error: > + kfree(strbuf); strbuf will be uninitialized if the iommu allocation fails. I don't have a particular preference for how to fix this but tend to dislike initial assignment with NULL because it hides other control flow issues. Regards Richard > + kfree(iommu); > prom_printf("sbus_iommu_init: Fatal memory allocation error.\n"); > } > >