From mboxrd@z Thu Jan 1 00:00:00 1970 From: kishon Subject: Re: [RFC PATCH 2/6] ARM: OMAP: USB: Add phy binding information Date: Thu, 17 Jan 2013 16:33:16 +0530 Message-ID: <50F7DA74.2020009@ti.com> References: <1358348462-27693-1-git-send-email-kishon@ti.com> <1358348462-27693-3-git-send-email-kishon@ti.com> <50F7C6C7.3030400@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <50F7C6C7.3030400@ti.com> Sender: linux-sh-owner@vger.kernel.org To: Roger Quadros Cc: devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org, linux-sh@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, balbi@ti.com, grant.likely@secretlab.ca, rob.herring@calxeda.com, rob@landley.net, b-cousson@ti.com, tony@atomide.com, linux@arm.linux.org.uk, horms@verge.net.au, magnus.damm@gmail.com, cbou@mail.ru, dwmw2@infradead.org, alexander.shishkin@linux.intel.com, gregkh@linuxfoundation.org, leoli@freescale.com, eric.y.miao@gmail.com, haojian.zhuang@gmail.com, stern@rowland.harvard.edu List-Id: linux-omap@vger.kernel.org Hi, On Thursday 17 January 2013 03:09 PM, Roger Quadros wrote: > On 01/16/2013 05:00 PM, Kishon Vijay Abraham I wrote: >> This is in preparation for the changes in PHY library to support adding >> and getting multiple PHYs of the same type. In the new design, the >> binding information between the PHY and the USB controller should be >> specified in the platform specific initialization code. So it's been >> done for OMAP platforms here. >> >> Signed-off-by: Kishon Vijay Abraham I >> --- >> This kind-of binding should be done in all the platforms (I've done only >> for OMAP platform). >> arch/arm/mach-omap2/usb-musb.c | 7 ++++++- >> 1 file changed, 6 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm/mach-omap2/usb-musb.c b/arch/arm/mach-omap2/usb-musb.c >> index 9d27e3f..bbe2fa5 100644 >> --- a/arch/arm/mach-omap2/usb-musb.c >> +++ b/arch/arm/mach-omap2/usb-musb.c >> @@ -24,6 +24,7 @@ >> #include >> #include >> #include >> +#include >> >> #include "omap_device.h" >> #include "soc.h" >> @@ -85,8 +86,12 @@ void __init usb_musb_init(struct omap_musb_board_data *musb_board_data) >> musb_plat.mode = board_data->mode; >> musb_plat.extvbus = board_data->extvbus; >> >> - if (cpu_is_omap44xx()) >> + if (cpu_is_omap44xx()) { >> musb_plat.has_mailbox = true; >> + usb_bind_phy("musb-hdrc.0.auto", 0, "omap-usb2.1.auto"); >> + } else if (cpu_is_omap34xx()) { >> + usb_bind_phy("musb-hdrc.0.auto", 0, "twl4030_usb"); >> + } > > Are you sure than these OMAP platforms cannot be wired in any other way > to the PHY? > > If they can be then this association must come from the board files or > device tree. I had given some thought about that and since all the existing OMAP platforms had it this way, I added it here. You having pointed that out, I'll move these to board files. Thanks Kishon From mboxrd@z Thu Jan 1 00:00:00 1970 From: kishon Date: Thu, 17 Jan 2013 11:15:16 +0000 Subject: Re: [RFC PATCH 2/6] ARM: OMAP: USB: Add phy binding information Message-Id: <50F7DA74.2020009@ti.com> List-Id: References: <1358348462-27693-1-git-send-email-kishon@ti.com> <1358348462-27693-3-git-send-email-kishon@ti.com> <50F7C6C7.3030400@ti.com> In-Reply-To: <50F7C6C7.3030400@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org Hi, On Thursday 17 January 2013 03:09 PM, Roger Quadros wrote: > On 01/16/2013 05:00 PM, Kishon Vijay Abraham I wrote: >> This is in preparation for the changes in PHY library to support adding >> and getting multiple PHYs of the same type. In the new design, the >> binding information between the PHY and the USB controller should be >> specified in the platform specific initialization code. So it's been >> done for OMAP platforms here. >> >> Signed-off-by: Kishon Vijay Abraham I >> --- >> This kind-of binding should be done in all the platforms (I've done only >> for OMAP platform). >> arch/arm/mach-omap2/usb-musb.c | 7 ++++++- >> 1 file changed, 6 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm/mach-omap2/usb-musb.c b/arch/arm/mach-omap2/usb-musb.c >> index 9d27e3f..bbe2fa5 100644 >> --- a/arch/arm/mach-omap2/usb-musb.c >> +++ b/arch/arm/mach-omap2/usb-musb.c >> @@ -24,6 +24,7 @@ >> #include >> #include >> #include >> +#include >> >> #include "omap_device.h" >> #include "soc.h" >> @@ -85,8 +86,12 @@ void __init usb_musb_init(struct omap_musb_board_data *musb_board_data) >> musb_plat.mode = board_data->mode; >> musb_plat.extvbus = board_data->extvbus; >> >> - if (cpu_is_omap44xx()) >> + if (cpu_is_omap44xx()) { >> musb_plat.has_mailbox = true; >> + usb_bind_phy("musb-hdrc.0.auto", 0, "omap-usb2.1.auto"); >> + } else if (cpu_is_omap34xx()) { >> + usb_bind_phy("musb-hdrc.0.auto", 0, "twl4030_usb"); >> + } > > Are you sure than these OMAP platforms cannot be wired in any other way > to the PHY? > > If they can be then this association must come from the board files or > device tree. I had given some thought about that and since all the existing OMAP platforms had it this way, I added it here. You having pointed that out, I'll move these to board files. Thanks Kishon From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <50F7DA74.2020009@ti.com> Date: Thu, 17 Jan 2013 16:33:16 +0530 From: kishon MIME-Version: 1.0 To: Roger Quadros Subject: Re: [RFC PATCH 2/6] ARM: OMAP: USB: Add phy binding information References: <1358348462-27693-1-git-send-email-kishon@ti.com> <1358348462-27693-3-git-send-email-kishon@ti.com> <50F7C6C7.3030400@ti.com> In-Reply-To: <50F7C6C7.3030400@ti.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Cc: linux-doc@vger.kernel.org, tony@atomide.com, linux@arm.linux.org.uk, linux-sh@vger.kernel.org, alexander.shishkin@linux.intel.com, stern@rowland.harvard.edu, devicetree-discuss@lists.ozlabs.org, linuxppc-dev@lists.ozlabs.org, rob.herring@calxeda.com, horms@verge.net.au, haojian.zhuang@gmail.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, eric.y.miao@gmail.com, b-cousson@ti.com, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, balbi@ti.com, cbou@mail.ru, rob@landley.net, dwmw2@infradead.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi, On Thursday 17 January 2013 03:09 PM, Roger Quadros wrote: > On 01/16/2013 05:00 PM, Kishon Vijay Abraham I wrote: >> This is in preparation for the changes in PHY library to support adding >> and getting multiple PHYs of the same type. In the new design, the >> binding information between the PHY and the USB controller should be >> specified in the platform specific initialization code. So it's been >> done for OMAP platforms here. >> >> Signed-off-by: Kishon Vijay Abraham I >> --- >> This kind-of binding should be done in all the platforms (I've done only >> for OMAP platform). >> arch/arm/mach-omap2/usb-musb.c | 7 ++++++- >> 1 file changed, 6 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm/mach-omap2/usb-musb.c b/arch/arm/mach-omap2/usb-musb.c >> index 9d27e3f..bbe2fa5 100644 >> --- a/arch/arm/mach-omap2/usb-musb.c >> +++ b/arch/arm/mach-omap2/usb-musb.c >> @@ -24,6 +24,7 @@ >> #include >> #include >> #include >> +#include >> >> #include "omap_device.h" >> #include "soc.h" >> @@ -85,8 +86,12 @@ void __init usb_musb_init(struct omap_musb_board_data *musb_board_data) >> musb_plat.mode = board_data->mode; >> musb_plat.extvbus = board_data->extvbus; >> >> - if (cpu_is_omap44xx()) >> + if (cpu_is_omap44xx()) { >> musb_plat.has_mailbox = true; >> + usb_bind_phy("musb-hdrc.0.auto", 0, "omap-usb2.1.auto"); >> + } else if (cpu_is_omap34xx()) { >> + usb_bind_phy("musb-hdrc.0.auto", 0, "twl4030_usb"); >> + } > > Are you sure than these OMAP platforms cannot be wired in any other way > to the PHY? > > If they can be then this association must come from the board files or > device tree. I had given some thought about that and since all the existing OMAP platforms had it this way, I added it here. You having pointed that out, I'll move these to board files. Thanks Kishon From mboxrd@z Thu Jan 1 00:00:00 1970 From: kishon@ti.com (kishon) Date: Thu, 17 Jan 2013 16:33:16 +0530 Subject: [RFC PATCH 2/6] ARM: OMAP: USB: Add phy binding information In-Reply-To: <50F7C6C7.3030400@ti.com> References: <1358348462-27693-1-git-send-email-kishon@ti.com> <1358348462-27693-3-git-send-email-kishon@ti.com> <50F7C6C7.3030400@ti.com> Message-ID: <50F7DA74.2020009@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On Thursday 17 January 2013 03:09 PM, Roger Quadros wrote: > On 01/16/2013 05:00 PM, Kishon Vijay Abraham I wrote: >> This is in preparation for the changes in PHY library to support adding >> and getting multiple PHYs of the same type. In the new design, the >> binding information between the PHY and the USB controller should be >> specified in the platform specific initialization code. So it's been >> done for OMAP platforms here. >> >> Signed-off-by: Kishon Vijay Abraham I >> --- >> This kind-of binding should be done in all the platforms (I've done only >> for OMAP platform). >> arch/arm/mach-omap2/usb-musb.c | 7 ++++++- >> 1 file changed, 6 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm/mach-omap2/usb-musb.c b/arch/arm/mach-omap2/usb-musb.c >> index 9d27e3f..bbe2fa5 100644 >> --- a/arch/arm/mach-omap2/usb-musb.c >> +++ b/arch/arm/mach-omap2/usb-musb.c >> @@ -24,6 +24,7 @@ >> #include >> #include >> #include >> +#include >> >> #include "omap_device.h" >> #include "soc.h" >> @@ -85,8 +86,12 @@ void __init usb_musb_init(struct omap_musb_board_data *musb_board_data) >> musb_plat.mode = board_data->mode; >> musb_plat.extvbus = board_data->extvbus; >> >> - if (cpu_is_omap44xx()) >> + if (cpu_is_omap44xx()) { >> musb_plat.has_mailbox = true; >> + usb_bind_phy("musb-hdrc.0.auto", 0, "omap-usb2.1.auto"); >> + } else if (cpu_is_omap34xx()) { >> + usb_bind_phy("musb-hdrc.0.auto", 0, "twl4030_usb"); >> + } > > Are you sure than these OMAP platforms cannot be wired in any other way > to the PHY? > > If they can be then this association must come from the board files or > device tree. I had given some thought about that and since all the existing OMAP platforms had it this way, I added it here. You having pointed that out, I'll move these to board files. Thanks Kishon From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755426Ab3AQLEL (ORCPT ); Thu, 17 Jan 2013 06:04:11 -0500 Received: from arroyo.ext.ti.com ([192.94.94.40]:55850 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752211Ab3AQLEJ (ORCPT ); Thu, 17 Jan 2013 06:04:09 -0500 Message-ID: <50F7DA74.2020009@ti.com> Date: Thu, 17 Jan 2013 16:33:16 +0530 From: kishon User-Agent: Mozilla/5.0 (X11; Linux i686; rv:15.0) Gecko/20120912 Thunderbird/15.0.1 MIME-Version: 1.0 To: Roger Quadros CC: , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [RFC PATCH 2/6] ARM: OMAP: USB: Add phy binding information References: <1358348462-27693-1-git-send-email-kishon@ti.com> <1358348462-27693-3-git-send-email-kishon@ti.com> <50F7C6C7.3030400@ti.com> In-Reply-To: <50F7C6C7.3030400@ti.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Thursday 17 January 2013 03:09 PM, Roger Quadros wrote: > On 01/16/2013 05:00 PM, Kishon Vijay Abraham I wrote: >> This is in preparation for the changes in PHY library to support adding >> and getting multiple PHYs of the same type. In the new design, the >> binding information between the PHY and the USB controller should be >> specified in the platform specific initialization code. So it's been >> done for OMAP platforms here. >> >> Signed-off-by: Kishon Vijay Abraham I >> --- >> This kind-of binding should be done in all the platforms (I've done only >> for OMAP platform). >> arch/arm/mach-omap2/usb-musb.c | 7 ++++++- >> 1 file changed, 6 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm/mach-omap2/usb-musb.c b/arch/arm/mach-omap2/usb-musb.c >> index 9d27e3f..bbe2fa5 100644 >> --- a/arch/arm/mach-omap2/usb-musb.c >> +++ b/arch/arm/mach-omap2/usb-musb.c >> @@ -24,6 +24,7 @@ >> #include >> #include >> #include >> +#include >> >> #include "omap_device.h" >> #include "soc.h" >> @@ -85,8 +86,12 @@ void __init usb_musb_init(struct omap_musb_board_data *musb_board_data) >> musb_plat.mode = board_data->mode; >> musb_plat.extvbus = board_data->extvbus; >> >> - if (cpu_is_omap44xx()) >> + if (cpu_is_omap44xx()) { >> musb_plat.has_mailbox = true; >> + usb_bind_phy("musb-hdrc.0.auto", 0, "omap-usb2.1.auto"); >> + } else if (cpu_is_omap34xx()) { >> + usb_bind_phy("musb-hdrc.0.auto", 0, "twl4030_usb"); >> + } > > Are you sure than these OMAP platforms cannot be wired in any other way > to the PHY? > > If they can be then this association must come from the board files or > device tree. I had given some thought about that and since all the existing OMAP platforms had it this way, I added it here. You having pointed that out, I'll move these to board files. Thanks Kishon