From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:49827)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1Tvnkj-00008g-UK
	for qemu-devel@nongnu.org; Thu, 17 Jan 2013 06:35:27 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1Tvnkj-0005Mr-00
	for qemu-devel@nongnu.org; Thu, 17 Jan 2013 06:35:25 -0500
Message-ID: <50F7E1F8.5010907@redhat.com>
Date: Thu, 17 Jan 2013 12:35:20 +0100
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <1358367600-8074-1-git-send-email-kwolf@redhat.com>
	<50F7D828.7090302@redhat.com>
In-Reply-To: <50F7D828.7090302@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 0/2] win32-aio fixes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com, qemu-stable@nongnu.org

Am 17.01.2013 11:53, schrieb Paolo Bonzini:
> Il 16/01/2013 21:19, Kevin Wolf ha scritto:
>> Paolo, especially the first one is worrying with respect to the test status of
>> this code. We should probably give it some additional testing.
>>
>> Kevin Wolf (2):
>>   win32-aio: Fix vectored reads
>>   win32-aio: Fix memory leak
>>
>>  block/win32-aio.c |    4 ++--
>>  1 files changed, 2 insertions(+), 2 deletions(-)
>>
> 
> Yes, the worrying part is especially that IIUC qtest does not support
> Windows.  There's no way to get good coverage without qtest.

Why that? If block drivers aren't testable from qemu-iotests with only
qemu-img and qemu-io, then there's something we did wrong. This specific
code would have been easily covered with qemu-io -k -n -c 'readv ...'
(which is how I found the bug and tested the fix).

Hm, or actually, is cache=none even needed for aio=native on Windows? In
any case I think some documentation needs to be updated.

qemu-iotests under Wine may need some polishing, though, and of course
needs someone to run it regularly with the right parameters. (In fact,
it seems we don't even run the tests with Linux AIO)

Kevin