All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laxman Dewangan <ldewangan@nvidia.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: Thierry Reding <thierry.reding@avionic-design.de>,
	Alan Cox <alan@linux.intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jslaby@suse.cz>, Stephen Warren <swarren@nvidia.com>,
	"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
	"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] serial: tegra: Switch to using struct tty_port
Date: Thu, 17 Jan 2013 23:04:41 +0530	[thread overview]
Message-ID: <50F83631.9080208@nvidia.com> (raw)
In-Reply-To: <50F82FE7.9090403@wwwdotorg.org>

On Thursday 17 January 2013 10:37 PM, Stephen Warren wrote:
> On 01/17/2013 06:31 AM, Thierry Reding wrote:
>> Many of the tty functions were converted to use a struct tty_port
>> instead of a struct tty_struct. Update the Tegra driver accordingly to
>> avoid build breakage.
> I tested that this does indeed fix the build warnings. I didn't test the
> resultant driver.
>
The api prototype changes and driver development went in parallel and 
hence the driver uses the older api. Both got merged on similar time and 
so out of sync.
I think this change is proper. I have not tested this change but 
reviewing code, it looks good to me.

Acked-By: Laxman Dewangan<ldewangan@nvidia.com>

  reply	other threads:[~2013-01-17 17:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-17 13:31 [PATCH] serial: tegra: Switch to using struct tty_port Thierry Reding
2013-01-17 13:31 ` Thierry Reding
2013-01-17 17:07 ` Stephen Warren
2013-01-17 17:34   ` Laxman Dewangan [this message]
     [not found]   ` <50F82FE7.9090403-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-01-18  8:37     ` Thierry Reding
2013-01-18  8:37       ` Thierry Reding
     [not found]       ` <20130118083756.GA3303-RM9K5IK7kjIyiCvfTdI0JKcOhU4Rzj621B7CTYaBSLdn68oJJulU0Q@public.gmane.org>
2013-01-18 15:49         ` Laxman Dewangan
2013-01-18 15:49           ` Laxman Dewangan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50F83631.9080208@nvidia.com \
    --to=ldewangan@nvidia.com \
    --cc=alan@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=swarren@nvidia.com \
    --cc=swarren@wwwdotorg.org \
    --cc=thierry.reding@avionic-design.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.