From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53221) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TvvZF-0008ED-LE for qemu-devel@nongnu.org; Thu, 17 Jan 2013 14:56:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TvvZB-0007LD-2p for qemu-devel@nongnu.org; Thu, 17 Jan 2013 14:56:05 -0500 Received: from mx1.redhat.com ([209.132.183.28]:14476) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TvvZA-0007Kp-Qq for qemu-devel@nongnu.org; Thu, 17 Jan 2013 14:56:01 -0500 Message-ID: <50F8574D.401@redhat.com> Date: Thu, 17 Jan 2013 12:55:57 -0700 From: Eric Blake MIME-Version: 1.0 References: <20130117185042.GQ10683@otherpad.lan.raisama.net> <1358449610-16466-1-git-send-email-ehabkost@redhat.com> In-Reply-To: <1358449610-16466-1-git-send-email-ehabkost@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2NWLAUCPTJQPHPUOGCOGF" Subject: Re: [Qemu-devel] [PATCH 1/8 v4] cutils: unsigned int parsing functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: Chegu Vinod , Laszlo Ersek , qemu-devel@nongnu.org, Anthony Liguori This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2NWLAUCPTJQPHPUOGCOGF Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 01/17/2013 12:06 PM, Eduardo Habkost wrote: > There are lots of duplicate parsing code using strto*() in QEMU, and > most of that code is broken in one way or another. Even the visitors > code have duplicate integer parsing code[1]. This introduces functions > to help parsing unsigned int values: parse_uint() and parse_uint_full()= =2E >=20 > Parsing functions for signed ints and floats will be submitted later. >=20 >=20 > Changes v4: > - Return -EINVAL in case a minus sign is found > - Make endptr point to beginning of string in case -EINVAL > is returned (like the strtoull() behavior) >=20 > v3->v4 interdiff: Thanks; that helped review. The rest of the series needs no modifications to enjoy the improvements of this v4 patch. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2NWLAUCPTJQPHPUOGCOGF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJQ+FdNAAoJEKeha0olJ0NqO04H/0e6yxRgbN89cqUXIzPqioyJ gDVDfWH/9IoirTE7P5YjSSRpP/3PY7sSER8UIJ14szozpN3hGwBvlHFgwc1ZVHEH 4zHxIC3tCsPPd8i8fjuZxStkvGhbpgN9sRzN4qrHPD+6xfDL8dIG+C9oN8wkaqZS Nk4NBHfjN8Z6n9GeeY+5Z2cuWtdbujrui6ciZYHbiqEykyHEP0+69m0wihm2aYfm KQThqQYSRR5FqfTCXKWQXdf4kt5bKefdbpEyJPsr9771zj0HugzxD3gPSXCIFF4w 3KsrlqosLkMnGlHVFD9PqLxWk7sIrAWozuBSUpGoBoHwGZTDYlo3SsDrY4JTaFg= =fuY/ -----END PGP SIGNATURE----- ------enig2NWLAUCPTJQPHPUOGCOGF--