From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40071) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TvwTP-00037o-5T for qemu-devel@nongnu.org; Thu, 17 Jan 2013 15:54:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TvwTN-00067R-Hc for qemu-devel@nongnu.org; Thu, 17 Jan 2013 15:54:07 -0500 Received: from v220110690675601.yourvserver.net ([78.47.199.172]:48680) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TvwTN-000667-Aq for qemu-devel@nongnu.org; Thu, 17 Jan 2013 15:54:05 -0500 Message-ID: <50F864EA.1080800@weilnetz.de> Date: Thu, 17 Jan 2013 21:54:02 +0100 From: Stefan Weil MIME-Version: 1.0 References: <1358359467-16638-1-git-send-email-sw@weilnetz.de> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] util: Fix compilation of envlist.c for MinGW List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: Paolo Bonzini , Anthony Liguori , qemu-devel@nongnu.org Am 17.01.2013 21:45, schrieb Blue Swirl: > On Wed, Jan 16, 2013 at 6:04 PM, Stefan Weil wrote: >> MinGW has no strtok_r, so we need a declaration in sysemu/os-win32.h. >> We must also fix the include statements in util/envlist.c to include >> that file. >> >> We currently don't need an implementation of strtok_r because the >> code is compiled but not linked for MinGW. > > I think it would be better to fix the build system so that unnecessary > files are not compiled. That's what I suggested first, but keeping things simple is also a good argument. Perhaps we should accept that libqemuutil.a can contain some unnecessary files (that's the status quo!). We also get the additional benefit of more portable code. Even if that portability is not needed for the moment, it might be useful later. Stefan