From mboxrd@z Thu Jan 1 00:00:00 1970 From: jianhai luan Subject: Re: [PATCH 4/4] review For Oracle bug 14470382 Date: Fri, 18 Jan 2013 09:57:48 +0800 Message-ID: <50F8AC1C.3060300@oracle.com> References: <50F8A979.6010709@oracle.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------050805020602010906080802" Return-path: In-Reply-To: <50F8A979.6010709@oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: gmarsden_org_ww@oracle.com, LINUX-UEK_WW@oracle.com, xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org This is a multi-part message in MIME format. --------------050805020602010906080802 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2013-1-18 9:46, jianhai luan wrote: > orabug: 14470382 > > When Dom0's network environment change, for example the issue, DomU > should send send gratuitous ARP initially to notify how to reach it. > > To fix the bug, we should modify backend and frontend at the same > time. For fixing frontend, i filer the new bug 16182568. The review > only to backend. > > For fixing the backend, I have 4 patch for review. [PATCH] Notify DomU to send gratuitous ARP initially by Connected->Connected transition > > Thanks, > Jason --------------050805020602010906080802 Content-Type: text/plain; charset=gb18030; name="0004-xen-netback-notify-frontend-to-send-gratuitous-ARP.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0004-xen-netback-notify-frontend-to-send-gratuitous-ARP.patc"; filename*1="h" RnJvbSA2ZDI3ZmU4OTM3M2IwMDBkNzUwYWUwYThiOWZiODMxMzU3ZTI4NmVkIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKYXNvbiBMdWFuIDxqaWFuaGFpLmx1YW5Ab3JhY2xl LmNvbT4gCkRhdGU6IEZyaSwgMjggRGVjIDIwMTIgMTU6NDM6MDYgKzA4MDAgClN1YmplY3Q6 IFtQQVRDSF0geGVuLW5ldGJhY2sgbm90aWZ5IGZyb250ZW5kIHRvIHNlbmQgZ3JhdHVpdG91 cyBBUlAuCgpJbiB0aGUgcmVhbCBuZXR3b3JrIGVudmlyb25tZW50LCBzb21lIGNhdXNlIHdp bGwgbGVhZAp0byBBY3RpdmUtQmFja3VwIG1vZGUgYm9uZGluZyBjaG9zZSBuZXcgYWN0aXZl ZCBwb3J0LgpBZnRlciB0aGF0LCB0aGUgdHJmZmljLCBkZXN0aW5hdGVkIHRvIERvbVUgYnkg aW5hY3RpdmVkCnBvcnQgKGZvcm1lciBhY3RpdmVkIHBvcnQpLCB3aWxsIGJlIHVucmVhY2hh YmxlIGF0IG5vdy4KRG9tVSBzaG91bGQgc2VuZCBncmF0dXRpb3VzIEFSUCBpbml0aWFsdGl2 bHkgdG8gZmluZCB0aGUKbmV3IGNvcnJlY3RlZCBwYXRoLgoKQnkgbmV0YmFjaydzIENvbm5l Y3RlZC0+Q29ubmVjdGVkIHRyYW5zaXRpb24sIGZyb250ZW5kIAp3aWxsIHdhdGNoIHRoZSBj aGFuZ2UsIGFuZCBzZW5kIGdyYXR1aXRvdXMgQVJQLgoKU2lnbmVkLW9mZi1ieTogSmFzb24g THVhbiA8amlhbmhhaS5sdWFuQG9yYWNsZS5jb20+Ci0tLQoKZGlmZiAtTnVyIGxpbnV4LTIu Ni4xOC5pNjg2Lm9yaWcvZHJpdmVycy94ZW4vbmV0YmFjay9jb21tb24uaCBsaW51eC0yLjYu MTguaTY4Ni9kcml2ZXJzL3hlbi9uZXRiYWNrL2NvbW1vbi5oCi0tLSBsaW51eC0yLjYuMTgu aTY4Ni5vcmlnL2RyaXZlcnMveGVuL25ldGJhY2svY29tbW9uLmgJMjAxMy0wMS0xNyAxNDoy MTo1MC4wMDAwMDAwMDAgKzA4MDAKKysrIGxpbnV4LTIuNi4xOC5pNjg2L2RyaXZlcnMveGVu L25ldGJhY2svY29tbW9uLmgJMjAxMy0wMS0xNyAxNDozMjo0OC4wMDAwMDAwMDAgKzA4MDAK QEAgLTE1MSw2ICsxNTEsOCBAQAogCXZvaWQgKm5ldGJhY2tfYWNjZWxfcHJpdjsKIAkvKiBU aGUgYWNjZWxlcmF0b3IgdGhhdCB0aGlzIGJhY2tlbmQgaXMgY3VycmVudGx5IHVzaW5nICov CiAJc3RydWN0IG5ldGJhY2tfYWNjZWxlcmF0b3IgKmFjY2VsZXJhdG9yOworCisJc3RydWN0 IG5vdGlmaWVyX2Jsb2NrIHZpZl9ub3RpZmllcjsKIH07CiAKICNkZWZpbmUgTkVUQkFDS19B Q0NFTF9WRVJTSU9OIDB4MDAwMTAwMDEKZGlmZiAtTnVyIGxpbnV4LTIuNi4xOC5pNjg2Lm9y aWcvZHJpdmVycy94ZW4vbmV0YmFjay94ZW5idXMuYyBsaW51eC0yLjYuMTguaTY4Ni9kcml2 ZXJzL3hlbi9uZXRiYWNrL3hlbmJ1cy5jCi0tLSBsaW51eC0yLjYuMTguaTY4Ni5vcmlnL2Ry aXZlcnMveGVuL25ldGJhY2sveGVuYnVzLmMJMjAxMy0wMS0xNyAxNDoyMTo1MC4wMDAwMDAw MDAgKzA4MDAKKysrIGxpbnV4LTIuNi4xOC5pNjg2L2RyaXZlcnMveGVuL25ldGJhY2sveGVu YnVzLmMJMjAxMy0wMS0xNyAxNDozNDowMi4wMDAwMDAwMDAgKzA4MDAKQEAgLTMzLDEwICsz Myw3MyBAQAogc3RhdGljIHZvaWQgY29ubmVjdChzdHJ1Y3QgYmFja2VuZF9pbmZvICopOwog c3RhdGljIHZvaWQgYmFja2VuZF9jcmVhdGVfbmV0aWYoc3RydWN0IGJhY2tlbmRfaW5mbyAq YmUpOwogCisvKioKKyAqIEJ5IENvbm5lY3RlZC0+Q29ubmVjdGVkIHRyYW5zaXRpb24sIG5l dGZyb250IHdpbGwgd2F0Y2ggdGhlIGNoYW5nZSBhbmQKKyAqIHNlbmQgZ3JhdHVpdG91cyBB UlAuCisgKi8KK3N0YXRpYyB2b2lkIG5vdGlmeV9mcm9udF9hcnBpbmcoc3RydWN0IHhlbmJ1 c19kZXZpY2UgKmRldikKK3sKKwlzdHJ1Y3QgeGVuYnVzX3RyYW5zYWN0aW9uIHhidDsKKwlp bnQgZXJyOworCisJaWYgKHhlbmJ1c19yZWFkX2RyaXZlcl9zdGF0ZShkZXYtPm5vZGVuYW1l KSAhPSBYZW5idXNTdGF0ZUNvbm5lY3RlZCkKKwkJcmV0dXJuOworCithZ2FpbjoKKwllcnIg PSB4ZW5idXNfdHJhbnNhY3Rpb25fc3RhcnQoJnhidCk7CisJaWYgKGVycikgeworCQlwcmlu dGsoS0VSTl9BTEVSVCAiRXJyb3Igc3RhcnRpbmcgdHJhbnNhY3Rpb24iKTsKKwkJcmV0dXJu OworCX0KKworCWVyciA9IHhlbmJ1c19wcmludGYoeGJ0LCBkZXYtPm5vZGVuYW1lLCAic3Rh dGUiLCAiJWQiLCBkZXYtPnN0YXRlKTsKKwlpZihlcnIpIHsKKwkJcHJpbnRrKEtFUk5fQUxF UlQgIkVycm9yIHdyaXRpbmcgdGhlIHN0YXRlIik7CisJCXhlbmJ1c190cmFuc2FjdGlvbl9l bmQoeGJ0LCAxKTsKKwkJcmV0dXJuOworCX0KKwkKKwllcnIgPSB4ZW5idXNfdHJhbnNhY3Rp b25fZW5kKHhidCwgMCk7CisJaWYgKGVyciA9PSAtRUFHQUlOKQorCQlnb3RvIGFnYWluOwor CWlmIChlcnIpCisJCXByaW50ayhLRVJOX0FMRVJUICJFcnJvciBlbmRpbmcgdHJhbnNhY3Rp b24iKTsKKworCXJldHVybjsKK30KKworI2RlZmluZSBuYl90b19iYWNrZW5kKG5iKSBjb250 YWluZXJfb2YobmIsIHN0cnVjdCBiYWNrZW5kX2luZm8sIHZpZl9ub3RpZmllcikKKy8qKgor ICogV2hlbiBuZXR3b3JrIGNvbmRpdGlvbiBvZiB2aWYgY2hhbmdlLCBub3RpZnkgdGhlIGZy b250ZW5kLgorICovCitzdGF0aWMgaW50IG5ldGJhY2tfbmV0ZGV2X2V2ZW50KHN0cnVjdCBu b3RpZmllcl9ibG9jayAqdGhpcywKKwkJdW5zaWduZWQgbG9uZyBldmVudCwgdm9pZCAqcHRy KQoreworCXN0cnVjdCBuZXRfZGV2aWNlICpldmVudF9kZXYgPSBwdHI7CisJc3RydWN0IGJh Y2tlbmRfaW5mbyAqYmUgPSBuYl90b19iYWNrZW5kKHRoaXMpOworCisJcHJfZGVidWcoImV2 ZW50X2RldjogJXMsIGV2ZW50OiAlbHhcbiIsCisJCWV2ZW50X2RldiA/IGV2ZW50X2Rldi0+ bmFtZSA6ICJOb25lIiwgZXZlbnQpOworCisJaWYgKCFiZS0+bmV0aWYpCisJCXJldHVybiBO T1RJRllfRE9ORTsKKwkKKwlzd2l0Y2ggKGV2ZW50KSB7CisJY2FzZSBORVRERVZfQk9ORElO R19GQUlMT1ZFUjoKKwkJLyogTm90aWZ5IGZyb250ZW5kIHRvIFNlbmQgZ3JhdHVpdG91cyBB UlAgKi8KKwkJbm90aWZ5X2Zyb250X2FycGluZyhiZS0+ZGV2KTsKKwkJYnJlYWs7CisJfQor CisJcmV0dXJuIE5PVElGWV9ET05FOworfQorCiBzdGF0aWMgaW50IG5ldGJhY2tfcmVtb3Zl KHN0cnVjdCB4ZW5idXNfZGV2aWNlICpkZXYpCiB7CiAJc3RydWN0IGJhY2tlbmRfaW5mbyAq YmUgPSBkZXYtPmRldi5kcml2ZXJfZGF0YTsKIAorCXVucmVnaXN0ZXJfbmV0ZGV2aWNlX25v dGlmaWVyKCZiZS0+dmlmX25vdGlmaWVyKTsKKwogCW5ldGJhY2tfcmVtb3ZlX2FjY2VsZXJh dG9ycyhiZSwgZGV2KTsKIAogCWlmIChiZS0+bmV0aWYpIHsKQEAgLTEzMiw2ICsxOTUsMTAg QEAKIAkvKiBUaGlzIGtpY2tzIGhvdHBsdWcgc2NyaXB0cywgc28gZG8gaXQgaW1tZWRpYXRl bHkuICovCiAJYmFja2VuZF9jcmVhdGVfbmV0aWYoYmUpOwogCisJLyogUmVnaXN0ZXIgRnJv bnRlbmQgRXZlbnQgTm90aWZ5ICovCisJYmUtPnZpZl9ub3RpZmllci5ub3RpZmllcl9jYWxs ID0gbmV0YmFja19uZXRkZXZfZXZlbnQ7CisJcmVnaXN0ZXJfbmV0ZGV2aWNlX25vdGlmaWVy KCZiZS0+dmlmX25vdGlmaWVyKTsKKwogCXJldHVybiAwOwogCiBhYm9ydF90cmFuc2FjdGlv bjoK --------------050805020602010906080802 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --------------050805020602010906080802--