All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bin Wang <wbin00@gmail.com>
To: linux-kernel@vger.kernel.org, Michal Marek <mmarek@suse.cz>
Subject: scripts/package: KBUILD_OUTPUT is useless in rpm build
Date: Fri, 18 Jan 2013 18:22:25 +0800	[thread overview]
Message-ID: <50F92261.4060100@gmail.com> (raw)

I found KBUILD_OUTPUT variable is useless in the rpm-pkg and rpm target.

Yes there is a comment said:

# Note that the rpm-pkg target cannot be used with KBUILD_OUTPUT,
# but the binrpm-pkg target can; for some reason O= gets ignored.

It does not say for what reason. Also, the code under rpm-pkg checks if 
KBUILD_OUTPUT is defined.

 > @if test -n "$(KBUILD_OUTPUT)"; then \
 >            echo "Building source + binary RPM is not possible outside 
the"; \
 >            echo "kernel source tree. Don't set KBUILD_OUTPUT, or use 
the"; \
 >            echo "binrpm-pkg target instead."; \
 >            false; \
 > fi

But the fact is, whether or not the user use "O=" option, KBUILD_OUTPUT 
is always empty. I try to figure out why but the big Makefile drives me 
crazy. I'm thinking if the "O=" option really don't effect KBUILD_OUTPUT 
here, at least remove these code.

-- 
Bin Wang


                 reply	other threads:[~2013-01-18 10:22 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50F92261.4060100@gmail.com \
    --to=wbin00@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.