From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Gwendal Grignou <gwendal@google.com>
Cc: jgarzik@pobox.com, linux-ide@vger.kernel.org
Subject: Re: [PATCH] [libata]Set proper SK when CK_COND is set.
Date: Fri, 18 Jan 2013 15:17:57 +0400 [thread overview]
Message-ID: <50F92F65.6060904@mvista.com> (raw)
In-Reply-To: <1358475510-23949-1-git-send-email-gwendal@google.com>
Hello.
On 18-01-2013 6:18, Gwendal Grignou wrote:
> When the user application sends a ATA_12 or ATA_16 PASSTHROUGH
> scsi command, put the task file register in the sense data with the
> proper Sense Key. Instead of NO SENSE, set RECOVERED, as
> specified in [SAT2]12.2.5 Table 92.
> Change-Id: Ia7d77d09f6db6db4796310b4dc9789ac0d7af69b
Remove this line please.
> Tested:
> Using udev ata_id to generate a passthrough command, IDENTIFY:
> before:
> sd 0:0:0:0: [sda] CDB: ATA command pass through(12)/Blank: \
> a1 08 2e 00 01 00 00 00 00 ec 00 00
> sd 0:0:0:0: [sda] Sense Key : No Sense [current] [descriptor]
> Descriptor sense data with sense descriptors (in hex):
> 72 00 00 00 00 00 00 0e 09 0c 00 00 00 00 00 3f
> 00 18 00 a6 e0 50
> after
> sd 0:0:0:0: [sda] CDB: ATA command pass through(12)/Blank: \
> a1 08 2e 00 01 00 00 00 00 ec 00 00
> sd 0:0:0:0: [sda] Sense Key : Recovered Error [current] [descriptor]
> Descriptor sense data with sense descriptors (in hex):
> 72 01 00 1d 00 00 00 0e 09 0c 00 00 00 01 00 00
> 00 00 00 00 00 50
> Signed-off-by: Gwendal Grignou <gwendal@google.com>
> ---
> drivers/ata/libata-scsi.c | 18 ++++++++++++++----
> 1 files changed, 14 insertions(+), 4 deletions(-)
> diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
> index 7c337e7..d5f81b2 100644
> --- a/drivers/ata/libata-scsi.c
> +++ b/drivers/ata/libata-scsi.c
[...]
> @@ -1733,10 +1741,12 @@ static void ata_scsi_qc_complete(struct ata_queued_cmd *qc)
>
> /* For ATA pass thru (SAT) commands, generate a sense block if
> * user mandated it or if there's an error. Note that if we
> - * generate because the user forced us to, a check condition
> - * is generated and the ATA register values are returned
> + * generate because the user forced us to [CK_COND =1 ], a check
Space before ] not needed.
MBR, Sergei
next prev parent reply other threads:[~2013-01-18 11:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-18 2:18 [PATCH] [libata]Set proper SK when CK_COND is set Gwendal Grignou
2013-01-18 11:17 ` Sergei Shtylyov [this message]
2013-01-18 18:56 ` Gwendal Grignou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F92F65.6060904@mvista.com \
--to=sshtylyov@mvista.com \
--cc=gwendal@google.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.