From: Mats Petersson <mats.petersson@citrix.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH] Add doc-comment to get_domain_by_id
Date: Fri, 18 Jan 2013 14:08:44 +0000 [thread overview]
Message-ID: <50F9576C.2050307@citrix.com> (raw)
In-Reply-To: <1358517777.3279.48.camel@zakaz.uk.xensource.com>
On 18/01/13 14:02, Ian Campbell wrote:
> On Fri, 2013-01-18 at 13:34 +0000, Mats Petersson wrote:
>> # HG changeset patch
>> # User Mats Petersson <mats.petersson@citrix.com>
>> # Date 1358516011 0
>> # Node ID 9662deb217d7869d35dce5587ae8a1b45296b3a0
>> # Parent 126ce5f1855ba21ae24fc1c0981e5c05a3245bad
>> Add doc-comment to get_domain_by_id
>>
>> diff --git a/xen/common/domain.c b/xen/common/domain.c
>> --- a/xen/common/domain.c
>> +++ b/xen/common/domain.c
> We normally put these comments in the header next to the protoype.
Ok, I can move it... ;)
>
>> @@ -373,7 +373,16 @@
>> free_cpumask_var(cpumask);
>> }
>>
>> -
>> +/**
> Nothing in the Xen infrastructure parses these sorts of headers and
> practically nowhere else uses them. I'd say just make this a regular
> comment.
And there I was searching for "how do you do doxygen style comments"
after having written a normal one, just so I could avoid being told that
"You should use doxygen format... " ;) I guess that's why I couldn't
trivially find something.
--
Mats
>
> Ian.
>
prev parent reply other threads:[~2013-01-18 14:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-18 13:34 [PATCH] Add doc-comment to get_domain_by_id Mats Petersson
2013-01-18 13:46 ` Mats Petersson
2013-01-18 14:02 ` Ian Campbell
2013-01-18 14:08 ` Mats Petersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F9576C.2050307@citrix.com \
--to=mats.petersson@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.