All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Ian Campbell <ian.campbell@citrix.com>
Cc: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH 1/4] tools: install under /usr/local by default.
Date: Fri, 18 Jan 2013 16:19:49 +0100	[thread overview]
Message-ID: <50F96815.1040405@citrix.com> (raw)
In-Reply-To: <1358519140-20052-1-git-send-email-ian.campbell@citrix.com>

On 18/01/13 15:25, Ian Campbell wrote:
> This is the defacto (or FHS mandated?) standard location for software
> built from source, in order to avoid clashing with packaged software
> which is installed under /usr/bin etc.
> 
> I think there is benefit in having Xen's install behave more like the
> majority of other OSS software out there.
> 
> The major downside here is in the transition from 4.2 to 4.3 where
> people who have built from source will innevitably discover breakage
> because 4.3 no longer overwrites stuff in /usr like it used to so they
> pickup old stale bits from /usr instead of new stuff from /usr/local.
> 
> Packages will use ./configure --prefix=/usr or whatever helper macro
> their package manager gives them. I have confirmed that doing this
> results in the same list of installed files as before this patch was
> applied.
> 
> Note that this does not currently affect docs or stubdoms at the
> moment, so they still end up under /usr. There are proposals to use
> configure here too at which point I would propose a similar patch and
> these would also move as expected (depending on the sequencing I may
> end folding that into this patch)

I think the above paragraph is no longer true, you are modifying
stubdoms configure to use the default prefix. Also the subject should be
updated to "tools/stubdom:" or a similar prefix.

> The hypervisor remains in /boot/ and there is no intention to move it.
> 
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>

Apart from the above comment, the code itself looks right, so:

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

  reply	other threads:[~2013-01-18 15:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-18 14:25 [PATCH 0/4] install into /usr/local and docs/configure Ian Campbell
2013-01-18 14:25 ` [PATCH 1/4] tools: install under /usr/local by default Ian Campbell
2013-01-18 15:19   ` Roger Pau Monné [this message]
2013-01-18 15:35     ` Ian Campbell
2013-01-20 23:57   ` Matt Wilson
2013-01-18 14:25 ` [PATCH 2/4] docs: Remove xen-api docs Ian Campbell
2013-01-18 14:25 ` [PATCH 3/4] docs: drop doxygen stuff Ian Campbell
2013-01-18 14:25 ` [PATCH 4/4] docs: check for documentation generation tools in docs/configure Ian Campbell
2013-01-18 16:12   ` Roger Pau Monné
2013-01-18 16:44     ` Ian Campbell
2013-01-18 17:46       ` Roger Pau Monné
2013-01-21  9:32         ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50F96815.1040405@citrix.com \
    --to=roger.pau@citrix.com \
    --cc=ian.campbell@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.