From: "Andreas Färber" <afaerber@suse.de>
To: Alexander Graf <agraf@suse.de>
Cc: "Blue Swirl" <blauwirbel@gmail.com>,
"Christian Borntraeger" <borntraeger@de.ibm.com>,
"Jens Freimann" <jfrei@linux.vnet.ibm.com>,
qemu-devel@nongnu.org, "Aurélien Jarno" <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH 2/8] s390: Move IPL code into a separate device
Date: Fri, 18 Jan 2013 19:37:56 +0100 [thread overview]
Message-ID: <50F99684.3070700@suse.de> (raw)
In-Reply-To: <1358532742-23156-3-git-send-email-agraf@suse.de>
Am 18.01.2013 19:12, schrieb Alexander Graf:
> diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c
> new file mode 100644
> index 0000000..7cbbf99
> --- /dev/null
> +++ b/hw/s390x/ipl.c
[...]
> +static TypeInfo s390_ipl_info = {
This should probably be static const - my tree-wide cleanup didn't catch
s390-next obviously. Please follow-up with a fix to avoid this being copied.
Similar issue could exist for ppc-next, please check.
Andreas
> + .class_init = s390_ipl_class_init,
> + .parent = TYPE_SYS_BUS_DEVICE,
> + .name = "s390-ipl",
> + .instance_size = sizeof(S390IPLState),
> +};
> +
> +static void s390_ipl_register_types(void)
> +{
> + type_register_static(&s390_ipl_info);
> +}
> +
> +type_init(s390_ipl_register_types)
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2013-01-18 18:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-18 18:12 [Qemu-devel] [PULL 0/8] s390 patch queue 2013-01-18 Alexander Graf
2013-01-18 18:12 ` [Qemu-devel] [PATCH 1/8] s390: new contributions GPLv2 or later Alexander Graf
2013-01-18 18:12 ` [Qemu-devel] [PATCH 2/8] s390: Move IPL code into a separate device Alexander Graf
2013-01-18 18:37 ` Andreas Färber [this message]
2013-01-18 18:12 ` [Qemu-devel] [PATCH 3/8] S390: Enable -cpu help and QMP query-cpu-definitions Alexander Graf
2013-01-18 18:12 ` [Qemu-devel] [PATCH 4/8] s390x: Remove inline function ebcdic_put and related data from cpu.h Alexander Graf
2013-01-18 18:12 ` [Qemu-devel] [PATCH 5/8] s390: Add CPU reset handler Alexander Graf
2013-01-18 18:12 ` [Qemu-devel] [PATCH 6/8] s390x: fix indentation Alexander Graf
2013-01-18 18:12 ` [Qemu-devel] [PATCH 7/8] target-s390x: Unregister reset callback on finalization Alexander Graf
2013-01-18 18:12 ` [Qemu-devel] [PATCH 8/8] s390: Add a hypercall registration interface Alexander Graf
2013-01-18 18:44 ` Andreas Färber
2013-01-19 13:57 ` [Qemu-devel] [PULL 0/8] s390 patch queue 2013-01-18 Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F99684.3070700@suse.de \
--to=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=aurelien@aurel32.net \
--cc=blauwirbel@gmail.com \
--cc=borntraeger@de.ibm.com \
--cc=jfrei@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.