From: Eric Blake <eblake@redhat.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: mdroth@linux.vnet.ibm.com, aliguori@us.ibm.com,
qemu-devel@nongnu.org, dietmar@proxmox.com, agl@us.ibm.com
Subject: Re: [Qemu-devel] [PATCH 1/3] balloon: drop old stats code & API
Date: Fri, 18 Jan 2013 13:01:01 -0700 [thread overview]
Message-ID: <50F9A9FD.2060200@redhat.com> (raw)
In-Reply-To: <1358537372-27320-2-git-send-email-lcapitulino@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 885 bytes --]
On 01/18/2013 12:29 PM, Luiz Capitulino wrote:
> Next commit will re-enable balloon stats with a different interface, but
> this old code conflicts with it. Let's drop it.
>
> It's important to note that the QMP and HMP interfaces are also dropped
> by this commit. That shouldn't be a problem though, because:
>
> 1. All QMP fields are optional
> 2. This feature has always been disabled
>
> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> ---
> hmp.c | 24 +-----------------------
> hw/virtio-balloon.c | 24 ------------------------
> qapi-schema.json | 20 +-------------------
> qmp-commands.hx | 13 -------------
> 4 files changed, 2 insertions(+), 79 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
next prev parent reply other threads:[~2013-01-18 20:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-18 19:29 [Qemu-devel] [PATCH v3 0/3] re-enable balloon stats Luiz Capitulino
2013-01-18 19:29 ` [Qemu-devel] [PATCH 1/3] balloon: drop old stats code & API Luiz Capitulino
2013-01-18 20:01 ` Eric Blake [this message]
2013-01-18 19:29 ` [Qemu-devel] [PATCH 2/3] balloon: re-enable balloon stats Luiz Capitulino
2013-01-18 20:04 ` Eric Blake
2013-01-18 19:29 ` [Qemu-devel] [PATCH 3/3] docs: document virtio-balloon stats Luiz Capitulino
2013-01-18 20:00 ` Eric Blake
2013-01-21 11:56 ` Luiz Capitulino
-- strict thread matches above, loose matches on Subject: below --
2012-12-14 15:49 [Qemu-devel] [PATCH v2 0/3] re-enable balloon stats Luiz Capitulino
2012-12-14 15:49 ` [Qemu-devel] [PATCH 1/3] balloon: drop old stats code & API Luiz Capitulino
2012-12-17 10:13 ` Dietmar Maurer
2012-12-17 11:57 ` Luiz Capitulino
2012-12-17 12:23 ` Dietmar Maurer
2012-12-17 12:33 ` Luiz Capitulino
2012-12-17 12:36 ` Dietmar Maurer
2012-12-17 12:39 ` Luiz Capitulino
2012-12-18 21:34 ` Eric Blake
2012-12-19 5:18 ` Dietmar Maurer
2012-12-19 11:27 ` Luiz Capitulino
2012-12-20 18:36 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F9A9FD.2060200@redhat.com \
--to=eblake@redhat.com \
--cc=agl@us.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=dietmar@proxmox.com \
--cc=lcapitulino@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.