From: Jason Luan <luanjianhai@163.com>
To: Jan Beulich <JBeulich@suse.com>, xen-devel@lists.xensource.com
Subject: Re: [PATCH 4/4] review For Oracle bug 14470382
Date: Sat, 19 Jan 2013 13:25:13 +0800 [thread overview]
Message-ID: <50FA2E39.8000304@163.com> (raw)
In-Reply-To: <50F9317202000078000B740F@nat28.tlf.novell.com>
于 2013年01月18日 18:26, Jan Beulich 写道:
>>>> On 18.01.13 at 11:08, Ian Campbell <Ian.Campbell@citrix.com> wrote:
>> However a single xenbus_printf as used here doesn't need a transaction
>> since it is only a single atomic operation.
> Right.
If the fact is that, the code will be simple. i will modify it.
>
>> On the other hand I'm not convinced that the initial read of the current
>> state didn't ought to be inside the transaction too, although I've not
>> thought about it terribly hard...
> I don't think so - this is just a safeguard, and I think it could as
> well look directly at dev->state.
Right, this is just a safeguard. you think that the below way is better?
if (dev->state != XenbusStateConnected)
return;
>
> Jan
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
Thanks,
Jason
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2013-01-19 5:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-18 1:46 review For Oracle bug 14470382 jianhai luan
2013-01-18 1:50 ` [PATCH 1/4]review " jianhai luan
2013-01-18 1:52 ` [PATCH 2/4] review " jianhai luan
2013-01-18 1:54 ` [PATCH 3/4] " jianhai luan
2013-01-18 1:57 ` [PATCH 4/4] " jianhai luan
2013-01-18 6:45 ` Dan Carpenter
2013-01-18 10:08 ` Ian Campbell
2013-01-18 10:26 ` Jan Beulich
2013-01-19 5:25 ` Jason Luan [this message]
2013-01-18 2:03 ` [Test Result] " jianhai luan
2013-01-18 2:38 ` jianhai luan
2013-01-18 2:44 ` jianhai luan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50FA2E39.8000304@163.com \
--to=luanjianhai@163.com \
--cc=JBeulich@suse.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.