From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vineet Gupta Subject: Re: [PATCH v2 48/76] ARC: Module support Date: Sat, 19 Jan 2013 17:26:36 +0530 Message-ID: <50FA89F4.9090203@synopsys.com> References: <1358511930-7424-1-git-send-email-vgupta@synopsys.com> <1358511930-7424-49-git-send-email-vgupta@synopsys.com> <201301181450.33444.arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-15" Content-Transfer-Encoding: 7bit Return-path: Received: from us01smtp3.synopsys.com ([198.182.44.81]:47982 "EHLO hermes.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751909Ab3ASL5s (ORCPT ); Sat, 19 Jan 2013 06:57:48 -0500 In-Reply-To: <201301181450.33444.arnd@arndb.de> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Arnd Bergmann Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org On Friday 18 January 2013 08:20 PM, Arnd Bergmann wrote: > On Friday 18 January 2013, Vineet Gupta wrote: > >> +int module_frob_arch_sections(Elf_Ehdr *hdr, Elf_Shdr *sechdrs, >> + char *secstr, struct module *mod) >> +{ >> + return 0; >> +} >> + >> +void module_arch_cleanup(struct module *mod) >> +{ >> +} >> + >> +int module_finalize(const Elf32_Ehdr *hdr, const Elf_Shdr *sechdrs, >> + struct module *mod) >> +{ >> + return 0; >> +} > These three empty functions are already defined __weak in kernel/module.c > so you can simply omit them here. > > Arnd Actually a subsequent patch to do dwarf unwinding out of modules has valid code in those. But yes I can take them out from this patch and introduce in the the one which really needs it. Thx, -Vineet From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752010Ab3ASL5u (ORCPT ); Sat, 19 Jan 2013 06:57:50 -0500 Received: from us01smtp3.synopsys.com ([198.182.44.81]:47982 "EHLO hermes.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751909Ab3ASL5s (ORCPT ); Sat, 19 Jan 2013 06:57:48 -0500 Message-ID: <50FA89F4.9090203@synopsys.com> Date: Sat, 19 Jan 2013 17:26:36 +0530 From: Vineet Gupta User-Agent: Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/20121011 Thunderbird/16.0.1 MIME-Version: 1.0 To: Arnd Bergmann CC: , Subject: Re: [PATCH v2 48/76] ARC: Module support References: <1358511930-7424-1-git-send-email-vgupta@synopsys.com> <1358511930-7424-49-git-send-email-vgupta@synopsys.com> <201301181450.33444.arnd@arndb.de> In-Reply-To: <201301181450.33444.arnd@arndb.de> Content-Type: text/plain; charset="ISO-8859-15" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.12.197.205] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 18 January 2013 08:20 PM, Arnd Bergmann wrote: > On Friday 18 January 2013, Vineet Gupta wrote: > >> +int module_frob_arch_sections(Elf_Ehdr *hdr, Elf_Shdr *sechdrs, >> + char *secstr, struct module *mod) >> +{ >> + return 0; >> +} >> + >> +void module_arch_cleanup(struct module *mod) >> +{ >> +} >> + >> +int module_finalize(const Elf32_Ehdr *hdr, const Elf_Shdr *sechdrs, >> + struct module *mod) >> +{ >> + return 0; >> +} > These three empty functions are already defined __weak in kernel/module.c > so you can simply omit them here. > > Arnd Actually a subsequent patch to do dwarf unwinding out of modules has valid code in those. But yes I can take them out from this patch and introduce in the the one which really needs it. Thx, -Vineet