From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48120) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TwZy6-0000rd-Jq for qemu-devel@nongnu.org; Sat, 19 Jan 2013 10:04:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TwZy5-00073S-Hl for qemu-devel@nongnu.org; Sat, 19 Jan 2013 10:04:26 -0500 Received: from isrv.corpit.ru ([86.62.121.231]:33133) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TwZy5-00073N-AF for qemu-devel@nongnu.org; Sat, 19 Jan 2013 10:04:25 -0500 Message-ID: <50FAB5F6.4020502@msgid.tls.msk.ru> Date: Sat, 19 Jan 2013 19:04:22 +0400 From: Michael Tokarev MIME-Version: 1.0 References: <1358607489-12478-1-git-send-email-mjt@msgid.tls.msk.ru> In-Reply-To: <1358607489-12478-1-git-send-email-mjt@msgid.tls.msk.ru> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] link seccomp only with softmmu targets List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Tokarev Cc: qemu-devel@nongnu.org, Eduardo Otubo 19.01.2013 18:58, Michael Tokarev wrote: > Now, if seccomp is detected, it is linked into every executable, > but is used only by softmmu targets (from vl.c). So link it > only where it is actually needed. Note this is not just a cleanup. For some reason, at least debian package of seccomp lacks static library (this needs separate investigation and maybe a fix), so when building linux-user-static targets the build fails, since libseccomp is linked into static linux-user executables. So consider it is a bugfix. Note that Makefile.objs adds qemu-seccomp.o to common-objs-y, -- maybe this whole variable (common-objs) should be renamed to softmmu-objs, to match other softmmu-* stuff? But I'm not sure I understand this makefile machinery. /mjt