Re: [Qemu-devel] [PATCH] link seccomp only with softmmu targets

[Paolo Bonzini <pbonzini@redhat.com>]

Il 19/01/2013 16:04, Michael Tokarev ha scritto:
> 
>> Now, if seccomp is detected, it is linked into every executable,
>> but is used only by softmmu targets (from vl.c).  So link it
>> only where it is actually needed.
> 
> Note this is not just a cleanup.  For some reason, at least
> debian package of seccomp lacks static library (this needs
> separate investigation and maybe a fix), so when building
> linux-user-static targets the build fails, since libseccomp
> is linked into static linux-user executables.
> 
> So consider it is a bugfix.

Ack.

> Note that Makefile.objs adds qemu-seccomp.o to common-objs-y, --
> maybe this whole variable (common-objs) should be renamed
> to softmmu-objs, to match other softmmu-* stuff?  But I'm
> not sure I understand this makefile machinery.

I'm going to unify common-obj-y/universal-obj-y/user-obj-y (see patches
from today) so that common-obj-y just means "built in the toplevel
directory for the target directories".

All of libs_softmmu etc. should probably be moved to the Makefiles as well.

Paolo