From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49872) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Twcpi-0001kZ-0B for qemu-devel@nongnu.org; Sat, 19 Jan 2013 13:08:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Twcpc-00034Q-Vo for qemu-devel@nongnu.org; Sat, 19 Jan 2013 13:07:57 -0500 Received: from mout.web.de ([212.227.15.4]:52166) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Twcpc-00034D-Kx for qemu-devel@nongnu.org; Sat, 19 Jan 2013 13:07:52 -0500 Message-ID: <50FAE0E7.7070200@web.de> Date: Sat, 19 Jan 2013 19:07:35 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1358524722-24542-1-git-send-email-andreas.faerber@web.de> <50F972C9.6090308@redhat.com> <50F97334.6080802@web.de> <50F97540.2010503@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH RFC for-1.4] qemu-thread-posix: Fix build for OpenBSD List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: Paolo Bonzini , qemu-devel@nongnu.org, Brad Smith Am 19.01.2013 10:44, schrieb Blue Swirl: > On Fri, Jan 18, 2013 at 4:16 PM, Paolo Bonzini wrote: >> Il 18/01/2013 17:07, Andreas Färber ha scritto: >>> Am 18.01.2013 17:05, schrieb Paolo Bonzini: >>>> Il 18/01/2013 16:58, Andreas Färber ha scritto: >>>>> Avoid an undefined reference to sem_timedwait. >>>>> >>>>> Signed-off-by: Andreas Färber >>>>> --- >>>>> include/qemu/thread-posix.h | 2 +- >>>>> util/qemu-thread-posix.c | 10 +++++----- >>>>> 2 Dateien geändert, 6 Zeilen hinzugefügt(+), 6 Zeilen entfernt(-) >>>>> >>>>> diff --git a/include/qemu/thread-posix.h b/include/qemu/thread-posix.h >>>>> index 0f30dcc..772d925 100644 >>>>> --- a/include/qemu/thread-posix.h >>>>> +++ b/include/qemu/thread-posix.h >>>>> @@ -12,7 +12,7 @@ struct QemuCond { >>>>> }; >>>>> >>>>> struct QemuSemaphore { >>>>> -#if defined(__APPLE__) || defined(__NetBSD__) >>>>> +#if defined(__APPLE__) || defined(__NetBSD__) || defined(__OpenBSD__) >>>>> pthread_mutex_t lock; >>>>> pthread_cond_t cond; >>>>> int count; [...] >>>> This was reverted recently. Apparently your OpenBSD is too old compared >>>> to what Brad wants to support... >>> >>> This is 5.1 from 2012. >> >> 2012 does sound a bit too recent, but then maybe not considering OpenBSD >> is only now getting a decent threading library. I suggest this >> approach: http://lwn.net/Articles/527216/ > > Brad, please correct me if I'm wrong, but I don't think OpenBSD > supports the previous releases, only the last release (5.2 was > released in November, 2012), -stable and -current: > http://www.openbsd.org/stable.html > http://www.openbsd.org/errata52.html Forgot to reply: I upgraded to 5.2 yesterday and that did fix this issue for me! Please drop this patch. I just need *some* working BSD system to test bsd-user with my upcoming CPU changes. Andreas > > This is a different approach to for example Ubuntu LTS, Debian stable or RHEL. > >> >> Paolo >> >> Paolo >> >>