From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50589) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TwctY-0002wH-Ak for qemu-devel@nongnu.org; Sat, 19 Jan 2013 13:12:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TwctU-0004Eb-I4 for qemu-devel@nongnu.org; Sat, 19 Jan 2013 13:11:56 -0500 Received: from cantor2.suse.de ([195.135.220.15]:56937 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TwctU-0004EL-8o for qemu-devel@nongnu.org; Sat, 19 Jan 2013 13:11:52 -0500 Message-ID: <50FAE1E3.6010309@suse.de> Date: Sat, 19 Jan 2013 19:11:47 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1358590008-1681-1-git-send-email-pbonzini@redhat.com> In-Reply-To: <1358590008-1681-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH for 1.4 0/4] Simplify Makefile.objs some more List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: blauwirbel@gmail.com, qemu-devel@nongnu.org Am 19.01.2013 11:06, schrieb Paolo Bonzini: > This small series makes some more simplifications to Makefile.objs, > removing two more variables: universal-obj-y and extra-obj-y, all > unified into common-obj-y. It also removes what remains of user-obj-y, > unifying that into common-obj-y as well. >=20 > To achieve this, the CONFIG_SOFTMMU and CONFIG_USER_ONLY symbols are > defined in the toplevel Makefile like we do with devices and disassembl= ers. > Another symbol, CONFIG_ALL, is defined only in the toplevel Makefile > and takes the place of extra-obj-y. >=20 > With this change the structure of Makefile.objs is finally reduced to o= nly > six recursive variables (stub-obj-y, util-obj-y, qga-obj-y, block-obj-y= , > common-obj-y, obj-y). More important, the simpler structure should hel= p > people modifying the build system, avoiding future proliferation of > variables as well. >=20 > The patches are mostly mechanical substitutions, and there is no > user-visible change---neither in total build time, nor in the files tha= t > are linked into the executables. Without having tested this yet I want to remind that it is necessary for qom/cpu.c to be built twice, to not run into similar issues like util/oslib-posix.c. Andreas >=20 > Please apply, thanks! >=20 > Paolo >=20 >=20 > Paolo Bonzini (4): > build: move around libcacard-y definition > build: use -$(CONFIG_SECCOMP) instead of ifeq > build: remove universal-obj-y > build: remove extra-obj-y >=20 > Makefile | 9 ++++----- > Makefile.objs | 43 ++++++++++++++++++------------------------= - > Makefile.target | 3 +-- > disas/Makefile.objs | 30 +++++++++++++++--------------- > fsdev/Makefile.objs | 8 ++++---- > hw/Makefile.objs | 10 +++++----- > hw/pci/Makefile.objs | 2 +- > qom/Makefile.objs | 4 ++-- > 8 files changed, 50 insertions(+), 59 deletions(-) >=20 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg