From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mark Zhang <nvmarkzhang@gmail.com>
Subject: Re: [PATCH] man: Fix typo and use $() for make expressions
Date: Sun, 20 Jan 2013 14:39:10 +0800
Message-ID: <50FB910E.70201@gmail.com>
References: <1358511721-22073-1-git-send-email-thierry.reding@avionic-design.de>
	<CANq1E4Rq5ONvGteRLeiFDjWRKLcm4_6=25dSOcGtsmAcO4KWSg@mail.gmail.com>
	<CANq1E4QSQ8yfvangqEqukMhaHcmNztkOnFFUVh-xxNy15vnuyA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org>
Received: from mail-da0-f41.google.com (mail-da0-f41.google.com
	[209.85.210.41])
	by gabe.freedesktop.org (Postfix) with ESMTP id B1717E5F29
	for <dri-devel@lists.freedesktop.org>;
	Sat, 19 Jan 2013 22:39:15 -0800 (PST)
Received: by mail-da0-f41.google.com with SMTP id e20so2236769dak.0
	for <dri-devel@lists.freedesktop.org>;
	Sat, 19 Jan 2013 22:39:15 -0800 (PST)
In-Reply-To: <CANq1E4QSQ8yfvangqEqukMhaHcmNztkOnFFUVh-xxNy15vnuyA@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
To: David Herrmann <dh.herrmann@googlemail.com>
Cc: dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

Hi David:

Sorry for jumping in. I pulled the ToT libdrm and it seems the manpages
will not be built("make html" does nothing), any suggestions?

P.S: I've installed xsltproc.

Mark
On 01/19/2013 12:01 AM, David Herrmann wrote:
> On Fri, Jan 18, 2013 at 5:00 PM, David Herrmann
> <dh.herrmann@googlemail.com> wrote:
>> Hi Thierry
>>
>> On Fri, Jan 18, 2013 at 1:22 PM, Thierry Reding
>> <thierry.reding@avionic-design.de> wrote:
>>> Due to the typo, none of the .xml files would end up in the release
>>> tarball and cause make distcheck as well as builds from the tarball to
>>> fail.
>>>
>>> Using $() isn't strictly necessary but other variables and expressions
>>> use that variant already so it makes the usage consistent.
>>
>> That's weird. "make distcheck" should not be able to build the
>> manpages if the XML files are not available. Also ${} is pretty
>> standard in makefiles, isn't it? I wonder what the problem here is. At
>> least distcheck runs fine on my machine.
> 
> Ah sorry, I now saw the "subs" => "subst" typo. Still I wonder why
> distcheck works here. But the patch looks fine. Thanks!
> 
>> Regards
>> David
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>