From: Sergei Shtylyov <sshtylyov@mvista.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] usb: gadget: precedence bug in show_requests()
Date: Sun, 20 Jan 2013 17:10:24 +0000 [thread overview]
Message-ID: <50FC2500.7060205@mvista.com> (raw)
In-Reply-To: <20130120145044.GA32551@elgon.mountain>
Hello.
On 20-01-2013 18:50, Dan Carpenter wrote:
> The mod operation has higher precedence than the divide
They are of the same priority AFAIR, but that doesn't matter since these
operations are executed left to right.
> but the intent
> was to divide first. It's supposed to count through one time for RX
> and a second time for TX but instead of doing "0 1 2 0 1 2" it does
> "0 0 1 1 2 2".
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> Static checker stuff. Untested.
> diff --git a/drivers/usb/chipidea/debug.c b/drivers/usb/chipidea/debug.c
> index 3bc244d..3cd223c 100644
> --- a/drivers/usb/chipidea/debug.c
> +++ b/drivers/usb/chipidea/debug.c
> @@ -709,7 +709,7 @@ static ssize_t show_requests(struct device *dev, struct device_attribute *attr,
>
> n += scnprintf(buf + n, PAGE_SIZE - n,
> "EP=%02i: TD=%08X %s\n",
> - i % ci->hw_ep_max/2, (u32)req->dma,
> + i % (ci->hw_ep_max / 2), (u32)req->dma,
> ((i < ci->hw_ep_max/2) ? "RX" : "TX"));
>
> for (j = 0; j < qSize; j++)
WBR, Sergei
next prev parent reply other threads:[~2013-01-20 17:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-20 14:50 [patch] usb: gadget: precedence bug in show_requests() Dan Carpenter
2013-01-20 17:10 ` Sergei Shtylyov [this message]
2013-01-20 17:21 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50FC2500.7060205@mvista.com \
--to=sshtylyov@mvista.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.