From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH 2/2] CDC_NCM: adding support FLAG_NOARP for Infineon modem platform Date: Sun, 20 Jan 2013 21:13:27 +0400 Message-ID: <50FC25B7.70708@mvista.com> References: <1358662329-8294-1-git-send-email-cpuwolf@gmail.com> <1358662329-8294-2-git-send-email-cpuwolf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: dcbw-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org, peter-Y+HMSxxDrH8@public.gmane.org, oneukum-l3A5Bk7waGM@public.gmane.org, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, alexey.orishko-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org, bjorn-yOkvZcmFvRU@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Wei Shuai Return-path: In-Reply-To: <1358662329-8294-2-git-send-email-cpuwolf-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org Hello. On 20-01-2013 10:12, Wei Shuai wrote: > Infineon(now Intel) HSPA Modem platform NCM cannot support ARP. we can define a new common structure wwan_noarp_info. Wrap your lines at 76-80 columns maximum please. > Then more similiar NO ARP devices can be handled easily > Signed-off-by: Wei Shuai > --- > drivers/net/usb/cdc_ncm.c | 21 +++++++++++++++++++++ > 1 files changed, 21 insertions(+), 0 deletions(-) > diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c > index 71b6e92..2d699b6 100644 > --- a/drivers/net/usb/cdc_ncm.c > +++ b/drivers/net/usb/cdc_ncm.c > @@ -1155,6 +1155,20 @@ static const struct driver_info wwan_info = { > .tx_fixup = cdc_ncm_tx_fixup, > }; > > +/* Same as wwan_info, but with IFF_NOARP */ FLAG_NOARP, you mean? > +static const struct driver_info wwan_noarp_info = { > + .description = "Mobile Broadband Network Device (NO ARP)", > + .flags = FLAG_POINTTOPOINT | FLAG_NO_SETINT | FLAG_MULTI_PACKET > + | FLAG_WWAN | FLAG_NOARP, WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html