All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gene Czarcinski <gene@czarc.net>
To: linux-btrfs@vger.kernel.org
Cc: Anand Jain <anand.jain@oracle.com>
Subject: Re: [PATCH 00/11 V3] add show command to the subvol sub command
Date: Sun, 20 Jan 2013 19:19:22 -0500	[thread overview]
Message-ID: <50FC898A.1070208@czarc.net> (raw)
In-Reply-To: <1357818083-15531-1-git-send-email-anand.jain@oracle.com>

On 01/10/2013 06:41 AM, Anand Jain wrote:
> This is an attempt to make btrfs cli more end user friendly.
> And adds show subcommand to display all known (as of now)
> information of the given subvol including its snapshot(s).
>
> The below patch:
>   "Btrfs-progs: accommodate different layout for printing subvol list"
> obsoletes the previosuly submitted patch
>   "Btrfs-progs: make provision to print subvol list tree format"
>
> Please provide your review comments. Thanks.
>
> An example output:
>
> First list out all the subvols/snapshots using the list subcommand.
>
> btrfs su list /btrfs
> ID 256 gen 10 top level 5 path sv1
> ID 259 gen 6 top level 5 path sv1/snap
> ID 260 gen 7 top level 5 path snap
> ID 261 gen 8 top level 5 path sv2
> ID 262 gen 9 top level 5 path sv1/snap2
> ID 263 gen 10 top level 5 path sv1/snap3
>
> Then use show subcommand to know all known information about the
> given subvol.
>
> btrfs su show /btrfs/sv1
> /btrfs/sv1
> 	uuid: 			508b12a5-ed2a-3942-af63-830967201070
> 	Parent uuid: 		-
> 	Creation time: 		2013-01-07 13:53:30
> 	Object ID: 		256
> 	Generation (Gen): 	10
> 	Gen at creation: 	5
> 	Parent: 		5
> 	Top Level: 		5
> 	Snapshot(s):
> 				sv1/snap
> 				sv1/snap2
> 				sv1/snap3
>
>
> v2->v3: List snapshots of the given subvol if any.
>          Uses a more simple approach to obtain the snapshots.
>
>
You have certainly been busy.  However, your patches need to be rebased 
considering some of the patch-sets currently sent to the mailing list.  
If nothing else, I would appreciate it if you could rebase to David 
Sterba's set.  And then there are the two patch-sets I submitted.

BTW, I do not claim anything except for the effort to scrapes these off 
the list to attempt getting btrfs-progs a bit more current with respect 
to bugfixes.  I was going to include "su show" but your latest 
submission is a bit too much for now.

Gene

  parent reply	other threads:[~2013-01-21  0:19 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-28  3:12 [PATCH 0/8 v2] add show command to the subvol sub command Anand jain
2012-12-28  3:12 ` [PATCH 1/8] Btrfs-progs: move open_file_or_dir() to utils.c Anand jain
2012-12-28  3:12 ` [PATCH 2/8] Btrfs-progs: Move printing outside of btrfs_list_subvols Anand jain
2012-12-28  3:12 ` [PATCH 3/8] Btrfs-progs: add parent uuid for snapshots Anand jain
2012-12-28  3:12 ` [PATCH 4/8] Btrfs-progs: move struct root_info to btrfs-list.h Anand jain
2012-12-28  3:12 ` [PATCH 5/8] Btrfs-progs: function to get root_info of a subvol Anand jain
2012-12-28  3:13 ` [PATCH 6/8] Btrfs-progs: provide method to check if filter is set Anand jain
2012-12-28  3:13 ` [PATCH 7/8] Btrfs-progs: add method to filter snapshots by parent uuid Anand jain
2012-12-28  3:13 ` [PATCH 8/8] Btrfs-progs: add show command to display detailed information about the subvol Anand jain
2013-01-10 11:41 ` [PATCH 00/11 V3] add show command to the subvol sub command Anand Jain
2013-01-10 11:41   ` [PATCH 01/11] Btrfs-progs: move open_file_or_dir() to utils.c Anand Jain
2013-01-10 11:41   ` [PATCH 02/11] Btrfs-progs: Move printing outside of btrfs_list_subvols Anand Jain
2013-01-10 11:41   ` [PATCH 03/11] Btrfs-progs: add parent uuid for snapshots Anand Jain
2013-01-10 11:41   ` [PATCH 04/11] Btrfs-progs: move struct root_info to btrfs-list.h Anand Jain
2013-01-10 11:41   ` [PATCH 05/11] Btrfs-progs: function to get root_info of a subvol Anand Jain
2013-01-10 11:41   ` [PATCH 06/11] Btrfs-progs: provide method to check if filter is set Anand Jain
2013-01-10 11:41   ` [PATCH 07/11] Btrfs-progs: add method to filter snapshots by parent uuid Anand Jain
2013-01-10 11:41   ` [PATCH 08/11] Btrfs-progs: put find_mount_root() in commands.h Anand Jain
2013-01-10 11:41   ` [PATCH 09/11] Btrfs-progs: maintain similar case in heading prefix Anand Jain
2013-01-10 11:41   ` [PATCH 10/11] Btrfs-progs: accommodate different layout for printing subvol list Anand Jain
2013-01-10 11:41   ` [PATCH 11/11] Btrfs-progs: add show to display all known parameters of the given subvol Anand Jain
2013-01-14  4:04   ` [PATCH 00/11 V3] add show command to the subvol sub command Anand Jain
2013-01-14 18:25     ` Goffredo Baroncelli
2013-01-15  8:05       ` Anand Jain
2013-01-15 18:37         ` Goffredo Baroncelli
2013-01-21  0:19   ` Gene Czarcinski [this message]
2013-01-21 10:35     ` Anand Jain
2013-01-23  8:30   ` Anand Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50FC898A.1070208@czarc.net \
    --to=gene@czarc.net \
    --cc=anand.jain@oracle.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.