From mboxrd@z Thu Jan 1 00:00:00 1970 From: Santosh Shilimkar Subject: Re: [PATCH 08/10] ARM: OMAP5: hwmod data: Create initial OMAP5 SOC hwmod data Date: Mon, 21 Jan 2013 13:41:36 +0530 Message-ID: <50FCF838.6000105@ti.com> References: <1358522856-12180-1-git-send-email-santosh.shilimkar@ti.com> <1358522856-12180-9-git-send-email-santosh.shilimkar@ti.com> <20130118171500.GC15361@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from bear.ext.ti.com ([192.94.94.41]:50024 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750926Ab3AUIKu (ORCPT ); Mon, 21 Jan 2013 03:10:50 -0500 In-Reply-To: <20130118171500.GC15361@atomide.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Tony Lindgren Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, mturquette@linaro.org, rnayak@ti.com, b-cousson@ti.com, Paul Walmsley On Friday 18 January 2013 10:45 PM, Tony Lindgren wrote: > Hi, > > * Santosh Shilimkar [130118 07:30]: >> From: Benoit Cousson >> >> Adding the hwmod data for OMAP54xx platforms. >> --- /dev/null >> +++ b/arch/arm/mach-omap2/omap_hwmod_54xx_data.c >> +/* bb2d */ >> +static struct omap_hwmod_irq_info omap54xx_bb2d_irqs[] = { >> + { .irq = 125 + OMAP54XX_IRQ_GIC_START }, >> + { .irq = -1 } >> +}; > ... > >> +/* c2c */ >> +static struct omap_hwmod_irq_info omap54xx_c2c_irqs[] = { >> + { .irq = 88 + OMAP54XX_IRQ_GIC_START }, >> + { .irq = -1 } >> +}; > ... > > >> +static struct omap_hwmod_dma_info omap54xx_c2c_sdma_reqs[] = { >> + { .dma_req = 68 + OMAP54XX_DMA_REQ_START }, >> + { .dma_req = -1 } >> +}; > > > >> +static struct omap_hwmod_addr_space omap54xx_elm_addrs[] = { >> + { >> + .pa_start = 0x48078000, >> + .pa_end = 0x48078fff, >> + .flags = ADDR_TYPE_RT >> + }, >> + { } >> +}; > ... > >> +static struct omap_hwmod_addr_space omap54xx_emif1_addrs[] = { >> + { >> + .pa_start = 0x4c000000, >> + .pa_end = 0x4c0003ff, >> + .flags = ADDR_TYPE_RT >> + }, >> + { } >> +}; > > As discussed earlier on this list, let's not duplicate the standard > resources here as they already are supposed to come from device tree. > > Whatever issues prevent us from dropping the duplicate data here need > to be fixed. I believe Benoit already had some scripts/patches for > that and was just waiting for the DMA binding to get merged? > Will have a loot at it. DMA binding pull request narrowly missed 3.8 but should get into 3.9. Regards santosh From mboxrd@z Thu Jan 1 00:00:00 1970 From: santosh.shilimkar@ti.com (Santosh Shilimkar) Date: Mon, 21 Jan 2013 13:41:36 +0530 Subject: [PATCH 08/10] ARM: OMAP5: hwmod data: Create initial OMAP5 SOC hwmod data In-Reply-To: <20130118171500.GC15361@atomide.com> References: <1358522856-12180-1-git-send-email-santosh.shilimkar@ti.com> <1358522856-12180-9-git-send-email-santosh.shilimkar@ti.com> <20130118171500.GC15361@atomide.com> Message-ID: <50FCF838.6000105@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Friday 18 January 2013 10:45 PM, Tony Lindgren wrote: > Hi, > > * Santosh Shilimkar [130118 07:30]: >> From: Benoit Cousson >> >> Adding the hwmod data for OMAP54xx platforms. >> --- /dev/null >> +++ b/arch/arm/mach-omap2/omap_hwmod_54xx_data.c >> +/* bb2d */ >> +static struct omap_hwmod_irq_info omap54xx_bb2d_irqs[] = { >> + { .irq = 125 + OMAP54XX_IRQ_GIC_START }, >> + { .irq = -1 } >> +}; > ... > >> +/* c2c */ >> +static struct omap_hwmod_irq_info omap54xx_c2c_irqs[] = { >> + { .irq = 88 + OMAP54XX_IRQ_GIC_START }, >> + { .irq = -1 } >> +}; > ... > > >> +static struct omap_hwmod_dma_info omap54xx_c2c_sdma_reqs[] = { >> + { .dma_req = 68 + OMAP54XX_DMA_REQ_START }, >> + { .dma_req = -1 } >> +}; > > > >> +static struct omap_hwmod_addr_space omap54xx_elm_addrs[] = { >> + { >> + .pa_start = 0x48078000, >> + .pa_end = 0x48078fff, >> + .flags = ADDR_TYPE_RT >> + }, >> + { } >> +}; > ... > >> +static struct omap_hwmod_addr_space omap54xx_emif1_addrs[] = { >> + { >> + .pa_start = 0x4c000000, >> + .pa_end = 0x4c0003ff, >> + .flags = ADDR_TYPE_RT >> + }, >> + { } >> +}; > > As discussed earlier on this list, let's not duplicate the standard > resources here as they already are supposed to come from device tree. > > Whatever issues prevent us from dropping the duplicate data here need > to be fixed. I believe Benoit already had some scripts/patches for > that and was just waiting for the DMA binding to get merged? > Will have a loot at it. DMA binding pull request narrowly missed 3.8 but should get into 3.9. Regards santosh