All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: tiwai@suse.de, alsa-devel@alsa-project.org,
	broonie@opensource.wolfsonmicro.com, swarren@nvidia.com,
	lgirdwood@gmail.com
Subject: Re: [PATCH 3/5] ASoC: tegra: Make 'ahub_auxdata' static
Date: Mon, 21 Jan 2013 10:16:30 -0700	[thread overview]
Message-ID: <50FD77EE.8030800@wwwdotorg.org> (raw)
In-Reply-To: <1358760566-3803-4-git-send-email-sachin.kamat@linaro.org>

On 01/21/2013 02:29 AM, Sachin Kamat wrote:
> Fixes the following sparse warning:
> sound/soc/tegra/tegra30_ahub.c:302:23: warning:
> symbol 'ahub_auxdata' was not declared. Should it be static?

> diff --git a/sound/soc/tegra/tegra30_ahub.c b/sound/soc/tegra/tegra30_ahub.c

> -struct of_dev_auxdata ahub_auxdata[] = {
> +static struct of_dev_auxdata ahub_auxdata[] = {

This array is being removed from the driver for 3.9 in a patch being
taken through the Tegra tree. As such, please drop this one patch.

The rest look fine to me, so the series,
Reviewed-by: Stephen Warren <swarren@nvidia.com>

  reply	other threads:[~2013-01-21 17:16 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-21  9:29 [PATCH 0/5] ASoC: tegra: Some fixes in codec files Sachin Kamat
2013-01-21  9:29 ` [PATCH 1/5] ASoC: tegra_wm9712: Remove __devinitconst attribute Sachin Kamat
2013-01-21  9:29 ` [PATCH 2/5] ASoC: tegra20_ac97: " Sachin Kamat
2013-01-21  9:29 ` [PATCH 3/5] ASoC: tegra: Make 'ahub_auxdata' static Sachin Kamat
2013-01-21 17:16   ` Stephen Warren [this message]
2013-01-22  4:56     ` Sachin Kamat
2013-01-21  9:29 ` [PATCH 4/5] ASoC: tegra: Use NULL instead of 0 for pointers Sachin Kamat
2013-01-21 17:15   ` Stephen Warren
2013-01-22  5:01     ` Sachin Kamat
2013-01-21  9:29 ` [PATCH 5/5] ASoC: tegra: Staticize some functions in tegra30_i2s.c Sachin Kamat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50FD77EE.8030800@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=lgirdwood@gmail.com \
    --cc=sachin.kamat@linaro.org \
    --cc=swarren@nvidia.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.