From mboxrd@z Thu Jan 1 00:00:00 1970 From: gregory.clement@free-electrons.com (Gregory CLEMENT) Date: Tue, 22 Jan 2013 10:09:03 +0100 Subject: [PATCH 1/6] arm: mvebu: Add support for local interrupt In-Reply-To: <20130121232637.GA3412@localhost> References: <1358790842-2986-1-git-send-email-gregory.clement@free-electrons.com> <1358790842-2986-2-git-send-email-gregory.clement@free-electrons.com> <20130121191744.0a04b941@skate> <50FDBC0E.1030706@free-electrons.com> <20130121232637.GA3412@localhost> Message-ID: <50FE572F.4090402@free-electrons.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 01/22/2013 12:26 AM, Ezequiel Garcia wrote: > Hi Thomas and Gregory, > > On Mon, Jan 21, 2013 at 11:07:10PM +0100, Gregory CLEMENT wrote: >> On 01/21/2013 07:17 PM, Thomas Petazzoni wrote: >>>> + irq_set_percpu_devid(virq); >>>> + irq_set_chip_and_handler(virq, &armada_370_xp_irq_chip, >>>> + handle_percpu_devid_irq); >>>> + >>>> + } else { >>>> + irq_set_chip_and_handler(virq, &armada_370_xp_irq_chip, >>>> + handle_level_irq); >>>> + } >>> >>> Braces useless since there is only one statement in the else. >>> > > IMHO, this is an exception to the rule. > Since the first block is more than one line, > we usually put braces on the single line block too. > (or at least that's what Documentation/CodingStyle says). > You're right! I would have liked to say I have done it on purpose, but in fact these braces are here only because during development I had had multiples lines inside the else. However, as you pointed it, I will keep it. > Regards, > -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gregory CLEMENT Subject: Re: [PATCH 1/6] arm: mvebu: Add support for local interrupt Date: Tue, 22 Jan 2013 10:09:03 +0100 Message-ID: <50FE572F.4090402@free-electrons.com> References: <1358790842-2986-1-git-send-email-gregory.clement@free-electrons.com> <1358790842-2986-2-git-send-email-gregory.clement@free-electrons.com> <20130121191744.0a04b941@skate> <50FDBC0E.1030706@free-electrons.com> <20130121232637.GA3412@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20130121232637.GA3412@localhost> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Ezequiel Garcia Cc: Lior Amsalem , Andrew Lunn , Ike Pan , John Stultz , David Marlin , Yehuda Yitschak , Jani Monoses , Russell King , Tawfik Bayouk , Dan Frazier , Eran Ben-Avi , Leif Lindholm , Sebastian Hesselbarth , Jason Cooper , Jon Masters , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Rob Herring , Thomas Gleixner , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Chris Van Hoof , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Maen Suleiman , Nadav Haklai , Shadi Ammouri List-Id: devicetree@vger.kernel.org On 01/22/2013 12:26 AM, Ezequiel Garcia wrote: > Hi Thomas and Gregory, > > On Mon, Jan 21, 2013 at 11:07:10PM +0100, Gregory CLEMENT wrote: >> On 01/21/2013 07:17 PM, Thomas Petazzoni wrote: >>>> + irq_set_percpu_devid(virq); >>>> + irq_set_chip_and_handler(virq, &armada_370_xp_irq_chip, >>>> + handle_percpu_devid_irq); >>>> + >>>> + } else { >>>> + irq_set_chip_and_handler(virq, &armada_370_xp_irq_chip, >>>> + handle_level_irq); >>>> + } >>> >>> Braces useless since there is only one statement in the else. >>> > > IMHO, this is an exception to the rule. > Since the first block is more than one line, > we usually put braces on the single line block too. > (or at least that's what Documentation/CodingStyle says). > You're right! I would have liked to say I have done it on purpose, but in fact these braces are here only because during development I had had multiples lines inside the else. However, as you pointed it, I will keep it. > Regards, > -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com