From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= Subject: Re: [PATCH RFC 02/10] libxl: add new hotplug interface support to hotplug script callers Date: Tue, 22 Jan 2013 10:30:39 +0100 Message-ID: <50FE5C3F.7070709@citrix.com> References: <1356109208-6830-1-git-send-email-roger.pau@citrix.com> <1356109208-6830-3-git-send-email-roger.pau@citrix.com> <1358515771.3279.33.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1358515771.3279.33.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On 18/01/13 14:29, Ian Campbell wrote: >> diff --git a/tools/libxl/libxl_netbsd.c b/tools/libxl/libxl_netbsd.c >> index 9587833..8061e7a 100644 >> --- a/tools/libxl/libxl_netbsd.c >> +++ b/tools/libxl/libxl_netbsd.c >> @@ -62,7 +62,7 @@ out: >> int libxl__get_hotplug_script_info(libxl__gc *gc, libxl__device *dev, >> char ***args, char ***env, >> libxl__device_action action, >> - int num_exec) >> + int num_exec, int hotplug_version) > > Is it worth wrapping verison and action into a little > libxl__hotplug_action struct? I'm going to pack hotplug_version and num_exec inside a libxl__hotplug_action struct, but not device_action, because device_action is not only used by hotplug scripts, it is also used by the general device connection/disconnection flow, and it will be strange to put it inside a hotplug specific struct.