From: mfuzzey@parkeon.com (Martin Fuzzey)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 0/5] W1: Support onewire master on i.MX53
Date: Tue, 22 Jan 2013 15:26:56 +0100 [thread overview]
Message-ID: <50FEA1B0.7060600@parkeon.com> (raw)
In-Reply-To: <20130122140941.GA4920@S2101-09.ap.freescale.net>
On 22/01/13 15:09, Shawn Guo wrote:
> On Tue, Jan 22, 2013 at 09:27:12AM +0100, Sascha Hauer wrote:
>> On Wed, Jan 16, 2013 at 03:57:49PM +0100, Martin Fuzzey wrote:
>>> W1: Support onewire master on i.MX53
>>> * Add device tree and pinctrl support to the MXC master driver
>>> * Convert to use devm_
>>> * Add i.MX53 clocks
>>> * Add i.MX53 device tree entries
>>>
>>> Changes since V1
>>> * Applied comments from Sascha Hauer:
>>> * Move patch converting driver to devm_ before the one adding devm_ based pinctrl
>>> * Fix existing unbalanced clk_prepare_enable/clk_disable_unprepare
>>> in probe error path
>>>
>>> * Place DT patch last since it includes pinctrls for driver.
>> This looks good now.
>>
>> Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
>>
>> You might have to send this again in two series, one for the w1
>> maintainer and one for arm-soc. Both series should be sufficiently
>> orthogonal.
>>
> Evgeniy has already ACK-ed the v1 series, so maybe he does not see any
> problem with the whole series going through one tree. In that case,
> we may just have it go via arm-soc tree? Otherwise, please let us
> know, Evgeniy.
>
> Shawn
>
There was also the question raised by Mark Rutland on the DT compatible
string.
Currently this is "fsl,imx21-owire" but Mark thought "fsl,imx21-w1" to
be better.
Do I take your Acks to mean "fsl,imx21-owire" is OK?
I should add a Documentation file for the DT binding too but I was
waiting for consensus
on the compatible string first.
Martin
WARNING: multiple messages have this Message-ID (diff)
From: Martin Fuzzey <mfuzzey-mB3Nsq4MPf1BDgjK7y7TUQ@public.gmane.org>
To: Shawn Guo <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: Evgeniy Polyakov <zbr-i6C2adt8DTjR7s880joybQ@public.gmane.org>,
Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH V2 0/5] W1: Support onewire master on i.MX53
Date: Tue, 22 Jan 2013 15:26:56 +0100 [thread overview]
Message-ID: <50FEA1B0.7060600@parkeon.com> (raw)
In-Reply-To: <20130122140941.GA4920-rvtDTF3kK1ictlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
On 22/01/13 15:09, Shawn Guo wrote:
> On Tue, Jan 22, 2013 at 09:27:12AM +0100, Sascha Hauer wrote:
>> On Wed, Jan 16, 2013 at 03:57:49PM +0100, Martin Fuzzey wrote:
>>> W1: Support onewire master on i.MX53
>>> * Add device tree and pinctrl support to the MXC master driver
>>> * Convert to use devm_
>>> * Add i.MX53 clocks
>>> * Add i.MX53 device tree entries
>>>
>>> Changes since V1
>>> * Applied comments from Sascha Hauer:
>>> * Move patch converting driver to devm_ before the one adding devm_ based pinctrl
>>> * Fix existing unbalanced clk_prepare_enable/clk_disable_unprepare
>>> in probe error path
>>>
>>> * Place DT patch last since it includes pinctrls for driver.
>> This looks good now.
>>
>> Acked-by: Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
>>
>> You might have to send this again in two series, one for the w1
>> maintainer and one for arm-soc. Both series should be sufficiently
>> orthogonal.
>>
> Evgeniy has already ACK-ed the v1 series, so maybe he does not see any
> problem with the whole series going through one tree. In that case,
> we may just have it go via arm-soc tree? Otherwise, please let us
> know, Evgeniy.
>
> Shawn
>
There was also the question raised by Mark Rutland on the DT compatible
string.
Currently this is "fsl,imx21-owire" but Mark thought "fsl,imx21-w1" to
be better.
Do I take your Acks to mean "fsl,imx21-owire" is OK?
I should add a Documentation file for the DT binding too but I was
waiting for consensus
on the compatible string first.
Martin
next prev parent reply other threads:[~2013-01-22 14:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-16 14:57 [PATCH V2 0/5] W1: Support onewire master on i.MX53 Martin Fuzzey
2013-01-16 14:57 ` [PATCH V2 1/5] W1: Add device tree support to MXC onewire master Martin Fuzzey
2013-01-16 14:57 ` [PATCH V2 2/5] ARM: i.MX53: Add clocks for i.mx53 " Martin Fuzzey
2013-01-16 14:57 ` [PATCH V2 3/5] W1: Convert MXC onewire master to devm_ functions Martin Fuzzey
2013-01-16 14:57 ` [PATCH V2 4/5] W1: Add pinctrl support to MXC onewire master Martin Fuzzey
2013-01-16 14:57 ` [PATCH V2 5/5] DTS: Add device tree entry for onewire master on i.MX53 Martin Fuzzey
2013-01-22 8:27 ` [PATCH V2 0/5] W1: Support " Sascha Hauer
2013-01-22 14:09 ` Shawn Guo
2013-01-22 14:26 ` Martin Fuzzey [this message]
2013-01-22 14:26 ` Martin Fuzzey
2013-01-22 14:35 ` Mark Rutland
2013-01-22 14:35 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50FEA1B0.7060600@parkeon.com \
--to=mfuzzey@parkeon.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.