From mboxrd@z Thu Jan 1 00:00:00 1970 From: Razvan Cojocaru Subject: Re: [PATCH] libxc, libxenstore: make the headers C++-friendly Date: Tue, 22 Jan 2013 19:18:46 +0200 Message-ID: <50FEC9F6.7060701@gmail.com> References: <93e5f6cf98d2ae3539db.1358873051@rcojocaru.dsd.ro> <50FED22102000078000B86C8@nat28.tlf.novell.com> <1358874166.3279.392.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1358874166.3279.392.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org Cc: Jan Beulich , xen-devel List-Id: xen-devel@lists.xenproject.org > Me neither. Perhaps everyone uses the macros and we get away with this > change? Not everyone. You'll notice that in the patch I had to modify tools/blktap2/drivers/tapdisk-vbd.c which used 'private' directly. > Was this change build tested, including stubdoms and other tools which > may rely on these headers? (qemu?) I did run 'make' and everything built with no errors on my machine. Thanks, Razvan Cojocaru