From: winton <newtonliuwen@gmail.com>
To: james.l.morris@oracle.com
Cc: linux-security-module@vger.kernel.org, linux-kbuild@vger.kernel.org
Subject: Security Kconfig is not common
Date: Wed, 23 Jan 2013 21:28:39 +0800 [thread overview]
Message-ID: <50FFE587.4020801@gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 401 bytes --]
Hi James,
Please help to review this patch.
When I analysis Kconfig files, I searched the keywork "source" and
then follow double quotations. The Kconfig in security is missing.
That's because security/Kconfig source keyword didn't using double
quotations.
Although that's may be not necessary. But I think the same as other
Kconfig files will be better.
Best regards,
Winton.Liu
[-- Attachment #2: 0001-Security-Kconfig-not-common.patch --]
[-- Type: text/x-patch, Size: 1715 bytes --]
From ccd2d4ddc01076570f23d3f4bfa5b3845a71524e Mon Sep 17 00:00:00 2001
From: "winton.liu" <newtonliuwen@gmail.com>
Date: Wed, 23 Jan 2013 21:08:33 +0800
Subject: [PATCH] Security Kconfig not common
Add dobule quotations in Kconfig source keyword.
That makes Kconfig files the same as other Kconfig.
It's more common.
Signed-off-by: winton.liu <newtonliuwen@gmail.com>
---
security/Kconfig | 12 ++++++------
security/integrity/Kconfig | 4 ++--
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/security/Kconfig b/security/Kconfig
index ccc61f8..e6936f2 100644
--- a/security/Kconfig
+++ b/security/Kconfig
@@ -183,13 +183,13 @@ config LSM_MMAP_MIN_ADDR
this low address space will need the permission specific to the
systems running LSM.
-source security/selinux/Kconfig
-source security/smack/Kconfig
-source security/tomoyo/Kconfig
-source security/apparmor/Kconfig
-source security/yama/Kconfig
+source "security/selinux/Kconfig"
+source "security/smack/Kconfig"
+source "security/tomoyo/Kconfig"
+source "security/apparmor/Kconfig"
+source "security/yama/Kconfig"
-source security/integrity/Kconfig
+source "security/integrity/Kconfig"
choice
prompt "Default security module"
diff --git a/security/integrity/Kconfig b/security/integrity/Kconfig
index 5bd1cc1..ba9147d 100644
--- a/security/integrity/Kconfig
+++ b/security/integrity/Kconfig
@@ -17,5 +17,5 @@ config INTEGRITY_SIGNATURE
This is useful for evm and module keyrings, when keys are
usually only added from initramfs.
-source security/integrity/ima/Kconfig
-source security/integrity/evm/Kconfig
+source "security/integrity/ima/Kconfig"
+source "security/integrity/evm/Kconfig"
--
1.7.9.5
next reply other threads:[~2013-01-23 13:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-23 13:28 winton [this message]
2013-01-23 16:30 ` Security Kconfig is not common Casey Schaufler
2013-01-24 10:26 ` winton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50FFE587.4020801@gmail.com \
--to=newtonliuwen@gmail.com \
--cc=james.l.morris@oracle.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.