Re: [pdx86-platform-drivers-x86:for-next 54/54] drivers/platform/x86/hp/hp-wmi.c:271:1: sparse: sparse: symbol 'active_platform_profile_lock' was not declared. Should it be static?

["Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>]

On Tue, 9 Jul 2024, kernel test robot wrote:

> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git for-next
> head:   2282159b33580076235384597df1d62a6a1037ee
> commit: 2282159b33580076235384597df1d62a6a1037ee [54/54] platform/x86: hp-wmi: Fix platform profile option switch bug on Omen and Victus laptops
> config: i386-randconfig-r122-20240709 (https://download.01.org/0day-ci/archive/20240709/202407092008.5HtUNn1c-lkp@intel.com/config)
> compiler: gcc-13 (Ubuntu 13.2.0-4ubuntu3) 13.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240709/202407092008.5HtUNn1c-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202407092008.5HtUNn1c-lkp@intel.com/
> 
> sparse warnings: (new ones prefixed by >>)
> >> drivers/platform/x86/hp/hp-wmi.c:271:1: sparse: sparse: symbol 'active_platform_profile_lock' was not declared. Should it be static?
> 
> vim +/active_platform_profile_lock +271 drivers/platform/x86/hp/hp-wmi.c
> 
>    266	
>    267	/*
>    268	 * Mutex for the active_platform_profile variable,
>    269	 * see omen_powersource_event.
>    270	 */
>  > 271	DEFINE_MUTEX(active_platform_profile_lock);
>    272	

Since this change was still the HEAD commit, I just added the missing 
static there and force pushed the for-next branch.

-- 
 i.