From mboxrd@z Thu Jan 1 00:00:00 1970 From: Francesco Lavra Subject: Re: [Linaro-mm-sig] [PATCH 4/7] fence: dma-buf cross-device synchronization (v11) Date: Wed, 23 Jan 2013 18:14:07 +0100 Message-ID: <51001A5F.1080903@gmail.com> References: <1358253244-11453-1-git-send-email-maarten.lankhorst@canonical.com> <1358253244-11453-5-git-send-email-maarten.lankhorst@canonical.com> <50FEAC87.7090702@gmail.com> <50FFFA31.6000101@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <50FFFA31.6000101@canonical.com> Sender: linux-kernel-owner@vger.kernel.org To: Maarten Lankhorst Cc: Maarten Lankhorst , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org List-Id: dri-devel@lists.freedesktop.org On 01/23/2013 03:56 PM, Maarten Lankhorst wrote: > Thanks for the review, how does this delta look? > > diff --git a/include/linux/fence.h b/include/linux/fence.h > index d9f091d..831ed0a 100644 > --- a/include/linux/fence.h > +++ b/include/linux/fence.h > @@ -42,7 +42,10 @@ struct fence_cb; > * @ops: fence_ops associated with this fence > * @cb_list: list of all callbacks to call > * @lock: spin_lock_irqsave used for locking > - * @priv: fence specific private data > + * @context: execution context this fence belongs to, returned by > + * fence_context_alloc() > + * @seqno: the sequence number of this fence inside the executation context, s/executation/execution Otherwise, looks good to me. -- Francesco