From: Daniel Dadap <ddadap@nvidia.com>
To: linux-kbuild@vger.kernel.org
Subject: [PATCH] KBUILD EXTMOD: Don't echo test -e for autoconf.h, even in verbose mode
Date: Wed, 23 Jan 2013 19:29:56 -0600 [thread overview]
Message-ID: <51008E94.7020702@nvidia.com> (raw)
The top-level Makefile tests to make sure autoconf.h is present before
building external modules. This test is performed silently unless
KBUILD_VERBOSE is set, in which case the test, along with the error
messages that gets printed when the test fails, shows up in `make`
output, regardless of whether the test succeeds.
Although there may be some utility in actually printing the test along
with the error message when building with KBUILD_VERBOSE, in practice,
the error message can confuse people building external modules.
Signed-off-by: Daniel Dadap <ddadap@nvidia.com>
Reviewed-by: Andy Ritger <aritger@nvidia.com>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 07bc925..11f1e69 100644
--- a/Makefile
+++ b/Makefile
@@ -537,7 +537,7 @@ else
PHONY += include/config/auto.conf
include/config/auto.conf:
- $(Q)test -e include/generated/autoconf.h -a -e $@ || ( \
+ @test -e include/generated/autoconf.h -a -e $@ || ( \
echo; \
echo " ERROR: Kernel configuration is invalid."; \
echo " include/generated/autoconf.h or $@ are missing.";\
--
1.7.10.4
-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information. Any unauthorized review, use, disclosure or distribution
is prohibited. If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------
reply other threads:[~2013-01-24 1:30 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51008E94.7020702@nvidia.com \
--to=ddadap@nvidia.com \
--cc=linux-kbuild@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.