All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wanlong Gao <gaowanlong@cn.fujitsu.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
	linux-kernel@vger.kernel.org, Jason Wang <jasowang@redhat.com>,
	Eric Dumazet <erdnetdev@gmail.com>,
	virtualization@lists.linux-foundation.org,
	netdev@vger.kernel.org
Subject: Re: [PATCH V6 1/3] virtio-net: fix the set affinity bug when CPU IDs are not consecutive
Date: Thu, 24 Jan 2013 10:28:55 +0800	[thread overview]
Message-ID: <51009C67.3090809@cn.fujitsu.com> (raw)
In-Reply-To: <87hamavx4n.fsf@rustcorp.com.au>

On 01/22/2013 09:12 AM, Rusty Russell wrote:
> Wanlong Gao <gaowanlong@cn.fujitsu.com> writes:
> 
>> As Michael mentioned, set affinity and select queue will not work very
>> well when CPU IDs are not consecutive, this can happen with hot unplug.
>> Fix this bug by traversal the online CPUs, and create a per cpu variable
>> to find the mapping from CPU to the preferable virtual-queue.
> 
> This series looks fairly sane at a glance, to me, but MST is the Ack you
> need.

Hi Michael,

Any comments?

Thanks,
Wanlong Gao

> 
> Thanks,
> Rusty.
> 


  reply	other threads:[~2013-01-24  2:34 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-21 11:25 [PATCH V6 1/3] virtio-net: fix the set affinity bug when CPU IDs are not consecutive Wanlong Gao
2013-01-21 11:25 ` Wanlong Gao
2013-01-21 11:25 ` [PATCH V6 2/3] virtio-net: split out clean affinity function Wanlong Gao
2013-01-21 11:25   ` Wanlong Gao
2013-01-25  3:28   ` Jason Wang
2013-01-25  3:28     ` Jason Wang
2013-01-25  4:20     ` Wanlong Gao
2013-01-25  4:20       ` Wanlong Gao
2013-01-25  5:13       ` Jason Wang
2013-01-25  5:13         ` Jason Wang
2013-01-25  5:40         ` Wanlong Gao
2013-01-25  5:40         ` Wanlong Gao
2013-01-25  6:12           ` Jason Wang
2013-01-25  6:12             ` Jason Wang
2013-01-25  6:42             ` Wanlong Gao
2013-01-25  6:42             ` Wanlong Gao
2013-01-25  7:04               ` Jason Wang
2013-01-25  7:04                 ` Jason Wang
2013-01-25  7:22                 ` Wanlong Gao
2013-01-25  7:22                   ` Wanlong Gao
2013-01-21 11:25 ` [PATCH V6 3/3] virtio-net: reset virtqueue affinity when doing cpu hotplug Wanlong Gao
2013-01-21 11:25 ` Wanlong Gao
2013-01-22  1:12 ` [PATCH V6 1/3] virtio-net: fix the set affinity bug when CPU IDs are not consecutive Rusty Russell
2013-01-24  2:28   ` Wanlong Gao [this message]
2013-01-24  2:28   ` Wanlong Gao
2013-01-22  1:12 ` Rusty Russell
2013-01-24 17:19 ` Michael S. Tsirkin
2013-01-24 17:19   ` Michael S. Tsirkin
2013-01-25  3:26 ` Jason Wang
2013-01-25  3:26   ` Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51009C67.3090809@cn.fujitsu.com \
    --to=gaowanlong@cn.fujitsu.com \
    --cc=erdnetdev@gmail.com \
    --cc=jasowang@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.