From: Dave Quigley <selinux@davequigley.com>
To: "Myklebust, Trond" <Trond.Myklebust@netapp.com>
Cc: Steve Dickson <steved@redhat.com>,
"J. Bruce Fields" <bfields@redhat.com>,
Linux NFS Mailing list <linux-nfs@vger.kernel.org>,
jmorris@namei.org, Stephen Smalley <sds@tycho.nsa.gov>,
eparis@redhat.com
Subject: Re: [PATCH 03/14] LSM: Add flags field to security_sb_set_mnt_opts for in kernel mount data.
Date: Wed, 23 Jan 2013 22:57:31 -0500 [thread overview]
Message-ID: <5100B12B.1090706@davequigley.com> (raw)
In-Reply-To: <4FA345DA4F4AE44899BD2B03EEEC2FA9183324A2@sacexcmbx05-prd.hq.netapp.com>
On 1/23/2013 1:35 PM, Myklebust, Trond wrote:
> On Tue, 2013-01-22 at 08:40 -0500, Steve Dickson wrote:
>> From: David Quigley <dpquigl@davequigley.com>
>>
>> There is no way to differentiate if a text mount option is passed from user
>> space or the kernel. A flags field is being added to the
>> security_sb_set_mnt_opts hook to allow for in kernel security flags to be sent
>> to the LSM for processing in addition to the text options received from mount.
>> This patch also updated existing code to fix compilation errors.
>>
>> Signed-off-by: David P. Quigley <dpquigl@tycho.nsa.gov>
>> Signed-off-by: Miguel Rodel Felipe <Rodel_FM@dsi.a-star.edu.sg>
>> Signed-off-by: Phua Eu Gene <PHUA_Eu_Gene@dsi.a-star.edu.sg>
>> Signed-off-by: Khin Mi Mi Aung <Mi_Mi_AUNG@dsi.a-star.edu.sg>
>> ---
>> fs/nfs/super.c | 3 ++-
>> include/linux/security.h | 13 ++++++++++---
>> security/capability.c | 5 ++++-
>> security/security.c | 7 +++++--
>> security/selinux/hooks.c | 12 ++++++++++--
>> 5 files changed, 31 insertions(+), 9 deletions(-)
>>
> Ditto. Need Acks from James, Stephen and Eric.
>
Adding James Morris, Steve Smalley, and Eric Paris for an ACK. These
patches have been reviewed on the security list many times in the past
and we're just now trying to get them mainlined again. All past comments
were addressed in them.
next prev parent reply other threads:[~2013-01-24 4:04 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-22 13:40 [PATCH 00/14] lNFS: 3.8-rc3 release Steve Dickson
2013-01-22 13:40 ` [PATCH 01/14] Security: Add hook to calculate context based on a negative dentry Steve Dickson
2013-01-23 18:31 ` Myklebust, Trond
2013-01-24 3:48 ` Dave Quigley
2013-01-24 4:29 ` Myklebust, Trond
2013-01-24 3:56 ` Dave Quigley
2013-01-22 13:40 ` [PATCH 02/14] Security: Add Hook to test if the particular xattr is part of a MAC model Steve Dickson
2013-01-23 18:32 ` Myklebust, Trond
2013-01-24 3:57 ` Dave Quigley
2013-01-22 13:40 ` [PATCH 03/14] LSM: Add flags field to security_sb_set_mnt_opts for in kernel mount data Steve Dickson
2013-01-23 18:35 ` Myklebust, Trond
2013-01-24 3:57 ` Dave Quigley [this message]
2013-01-22 13:40 ` [PATCH 04/14] SELinux: Add new labeling type native labels Steve Dickson
2013-01-23 18:36 ` Myklebust, Trond
2013-01-24 3:57 ` Dave Quigley
2013-01-22 13:40 ` [PATCH 05/14] KConfig: Add KConfig entries for Labeled NFS Steve Dickson
2013-01-23 18:37 ` Myklebust, Trond
2013-01-24 3:58 ` Dave Quigley
2013-01-22 13:40 ` [PATCH 06/14] NFSv4: Add label recommended attribute and NFSv4 flags Steve Dickson
2013-01-23 18:41 ` Myklebust, Trond
2013-01-22 13:40 ` [PATCH 07/14] NFSv4: Introduce new label structure Steve Dickson
2013-01-23 19:07 ` Myklebust, Trond
2013-01-22 13:40 ` [PATCH 08/14] NFSv4: Extend fattr bitmaps to support all 3 words Steve Dickson
2013-01-23 19:12 ` Myklebust, Trond
2013-01-22 13:40 ` [PATCH 09/14] NFS:Add labels to client function prototypes Steve Dickson
2013-01-22 13:40 ` [PATCH 10/14] NFS: Add label lifecycle management Steve Dickson
2013-01-23 19:31 ` Myklebust, Trond
2013-01-22 13:40 ` [PATCH 11/14] NFS: Client implementation of Labeled-NFS Steve Dickson
2013-01-23 19:46 ` Myklebust, Trond
2013-01-22 13:40 ` [PATCH 12/14] NFS: Extend NFS xattr handlers to accept the security namespace Steve Dickson
2013-01-22 13:40 ` [PATCH 13/14] NFSD: Server implementation of MAC Labeling Steve Dickson
2013-01-22 13:40 ` [PATCH 14/14] lnfs: Do not sleep holding the inode spin lock Steve Dickson
2013-01-23 19:49 ` Myklebust, Trond
2013-01-23 17:07 ` [PATCH 00/14] lNFS: 3.8-rc3 release J. Bruce Fields
2013-01-23 17:59 ` Steve Dickson
2013-01-23 19:16 ` J. Bruce Fields
2013-01-24 3:47 ` Dave Quigley
-- strict thread matches above, loose matches on Subject: below --
2013-02-18 18:47 [PATCH 00/14] lnfs: 3.8-rc7 release Steve Dickson
2013-02-18 18:47 ` [PATCH 03/14] LSM: Add flags field to security_sb_set_mnt_opts for in kernel mount data Steve Dickson
2013-03-25 11:42 [PATCH 00/14] lnfs: 3.9-rc3 release Steve Dickson
2013-03-25 11:42 ` [PATCH 03/14] LSM: Add flags field to security_sb_set_mnt_opts for in kernel mount data Steve Dickson
2013-03-28 13:53 [PATCH 00/14] nfs: 3.9-rc3 release (v2) Steve Dickson
2013-03-28 13:53 ` [PATCH 03/14] LSM: Add flags field to security_sb_set_mnt_opts for in kernel mount data Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5100B12B.1090706@davequigley.com \
--to=selinux@davequigley.com \
--cc=Trond.Myklebust@netapp.com \
--cc=bfields@redhat.com \
--cc=eparis@redhat.com \
--cc=jmorris@namei.org \
--cc=linux-nfs@vger.kernel.org \
--cc=sds@tycho.nsa.gov \
--cc=steved@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.