All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pascal Ouyang <xin.ouyang@windriver.com>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] libcgroup: fix the QA issue for pam_cgroup.so*
Date: Thu, 24 Jan 2013 14:28:07 +0800	[thread overview]
Message-ID: <5100D477.9040305@windriver.com> (raw)
In-Reply-To: <CAJTo0Lbg6OyQ=eWun_fp_01AbX8Ybcf+Cmw+9MKPVk7tLxoZqA@mail.gmail.com>

于 2013年01月23日 20:00, Burton, Ross 写道:
> On 23 January 2013 02:31, Xin Ouyang <Xin.Ouyang@windriver.com> wrote:
>> pam modules in ${base_libdir}/security/ should be binary .so files,
>> not symlinks. So fix this QA issue.
>
> The short log should explain the problem more than just "fix QA issue".
>
> The commit log also doesn't say anything about moving libcgroup from
> /usr/lib to /lib.  Also isn't just setting --libdir in EXTRA_OEMAKE
> cleaner?


You know pam_cgroup.so is installed into ${base_libdir}/security, this 
will cause "unsafe-references-in-binaries" QA issue if libcgroup.so.0 is 
installed into ${libdir}.

I will add this reason in V2.

I do not use --libdir because pkgconfig/dev-so files should always 
installed into ${libdir} instead of ${base_libdir}.

>
> Finally, no PR bumps are needed in oe-core.

Why no PR bumps needed?

Thanks. :)

- Pascal

>
> Ross
>
>


-- 
- Pascal



  reply	other threads:[~2013-01-24  8:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-23  2:31 [PATCH] libcgroup: fix the QA issue for pam_cgroup.so* Xin Ouyang
2013-01-23 12:00 ` Burton, Ross
2013-01-24  6:28   ` Pascal Ouyang [this message]
2013-01-24 10:46     ` Burton, Ross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5100D477.9040305@windriver.com \
    --to=xin.ouyang@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=ross.burton@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.