diff for duplicates of <5100EF60.1080409@bfs.de> diff --git a/a/1.txt b/N1/1.txt index 523429f..1e119f8 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -20,14 +20,14 @@ Am 24.01.2013 07:38, schrieb Dan Carpenter: > + /* "pim6reg%u" should not exceed 16 bytes (IFNAMSIZ) */ > + if (v != RT_TABLE_DEFAULT && v >= 100000000) > + return -EINVAL; -> if (sk = mrt->mroute6_sk) +> if (sk == mrt->mroute6_sk) > return -EBUSY; > hi Dan, that comment left me in a bit confused, i guess you men printf( "pim6reg%u",v) should not exceed IFNAMSIZ (16 bytes) ? also the if is a bit strange, i assume that RT_TABLE_DEFAULT is const -so anything else is rejected than v=RT_TABLE_DEFAULT +so anything else is rejected than v==RT_TABLE_DEFAULT (assuming that RT_TABLE_DEFAULT >= 100000000 ....) re, diff --git a/a/content_digest b/N1/content_digest index 2504224..4c3cc66 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\020130124063834.GA5611@elgon.mountain\0" "From\0walter harms <wharms@bfs.de>\0" "Subject\0Re: [patch] ip6mr: limit IPv6 MRT_TABLE identifiers\0" - "Date\0Thu, 24 Jan 2013 08:22:56 +0000\0" + "Date\0Thu, 24 Jan 2013 09:22:56 +0100\0" "To\0Dan Carpenter <dan.carpenter@oracle.com>\0" "Cc\0David S. Miller <davem@davemloft.net>" Alexey Kuznetsov <kuznet@ms2.inr.ac.ru> @@ -34,14 +34,14 @@ "> +\t\t/* \"pim6reg%u\" should not exceed 16 bytes (IFNAMSIZ) */\n" "> +\t\tif (v != RT_TABLE_DEFAULT && v >= 100000000)\n" "> +\t\t\treturn -EINVAL;\n" - "> \t\tif (sk = mrt->mroute6_sk)\n" + "> \t\tif (sk == mrt->mroute6_sk)\n" "> \t\t\treturn -EBUSY;\n" "> \n" "hi Dan,\n" "that comment left me in a bit confused, i guess you men\n" " printf( \"pim6reg%u\",v) should not exceed IFNAMSIZ (16 bytes) ?\n" "also the if is a bit strange, i assume that RT_TABLE_DEFAULT is const\n" - "so anything else is rejected than v=RT_TABLE_DEFAULT\n" + "so anything else is rejected than v==RT_TABLE_DEFAULT\n" "(assuming that RT_TABLE_DEFAULT >= 100000000 ....)\n" "\n" "re,\n" @@ -55,4 +55,4 @@ "> \n" > -d374546b89c649fc5303612c3645f0ea2dea800b0af3e50f3a2e0606c318b5b5 +c9286c615dc89a7ba3af5f423334da8cf806b330f7c590ffc58bc91eb1f6d24e
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.