From: Cor Peters <cpeters@victronenergy.com>
To: <linux-watchdog@vger.kernel.org>
Subject: Re: omap watchdog boot status
Date: Wed, 9 Nov 2016 15:40:26 +0100 [thread overview]
Message-ID: <51015056.IPIqE8z1xd@corpeters> (raw)
In-Reply-To: <8d23fff0-5e47-e623-f367-b2605b796bdf@roeck-us.net>
On Monday 07 November 2016 17:12:56 Guenter Roeck wrote:
> On 11/07/2016 06:26 AM, Cor Peters wrote:
> > Hello everybody
> >
> > I was looking into an issue with the omap-wdt.c. The watchdog driver not is
> > reporting a different boot status when a reset is being triggered by the
> > watchdog.
> >
> >>From what I gathered, the issue is that in the omap_wdt_probe function,
> > pdev->dev->platform_data requires to be a reference to the PRM module,
> > however it has not been set, and I was wondering how this should work in
> > an environment that uses the device tree method. (Link to usage:
> > http://lxr.free-electrons.com/source/drivers/watchdog/omap_wdt.c#L268[1] ).
> >
> > My questions are as follows:
> > 1) Is my assertion correct that the current method does not work when
> > the driver is being initialised from an device tree instead of a old style
> > board file.
>
> I think you are correct.
>
> > 2) If that is the case, what would be the best method of fixing this situation.
> >
> I am not a devicetree expert, but you may have to define a property to point to
> the register and bit providing the necessary information. This could possibly
> be done with syscon, but I really don't know enough about it to really know for
> sure what the best approach would be.
Thanks, syscon seems like a good solution.
> Guenter
>
Cor
prev parent reply other threads:[~2016-11-09 14:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-07 14:26 omap watchdog boot status Cor Peters
2016-11-08 1:12 ` Guenter Roeck
2016-11-09 14:40 ` Cor Peters [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51015056.IPIqE8z1xd@corpeters \
--to=cpeters@victronenergy.com \
--cc=linux-watchdog@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.